Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2894473002: Remove -Wno-deprecated from linux and android (Closed)

Created:
3 years, 7 months ago by scottmg
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove -Wno-deprecated from linux and android Side investigation for getting base compiling on Fuchsia. BUG=706592 Review-Url: https://codereview.chromium.org/2894473002 Cr-Commit-Position: refs/heads/master@{#472690} Committed: https://chromium.googlesource.com/chromium/src/+/3ac652888aa83444ea37c627b6537af80bee772b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
scottmg
Appears to have been placebo.
3 years, 7 months ago (2017-05-17 23:05:55 UTC) #5
Nico
lgtm!
3 years, 7 months ago (2017-05-17 23:09:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894473002/1
3 years, 7 months ago (2017-05-17 23:15:50 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 05:52:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3ac652888aa83444ea37c627b653...

Powered by Google App Engine
This is Rietveld 408576698