Rename interstitial_v2 files

Rename interstitial_v2 files

1) I removed v1 a long time ago. It isn't relevant anymore that some
   files are v2.
2) This lets us differentiate between loud and quiet interstitials.
3) interstitial_ui.html was named confusingly (it is too similar to the
   others) so I gave it a more clear name.

BUG=

Review-Url: https://codereview.chromium.org/2894413003
Cr-Commit-Position: refs/heads/master@{#478096}
Committed: https://chromium.googlesource.com/chromium/src/+/5d92ae69ae7b36fe1b3cc15ee947aa811f635897

[felt, 2017-05-22 22:56:59]

The CQ bit was checked by felt@chromium.org to run a CQ dry run

[felt, 2017-05-22 22:57:14]

Description was changed from

==========
Rename interstitial_v2 files

1) I removed v1 a long time ago. It isn't relevant anymore that some
   files are v2.
2) This lets us differentiate between loud and quiet interstitials.
3) interstitial_ui.html was named confusingly (it is too similar to the
   others) so I gave it a more clear name.

BUG=
==========

to

==========
Rename interstitial_v2 files

1) I removed v1 a long time ago. It isn't relevant anymore that some
   files are v2.
2) This lets us differentiate between loud and quiet interstitials.
3) interstitial_ui.html was named confusingly (it is too similar to the
   others) so I gave it a more clear name.

BUG=
==========

[felt, 2017-05-22 22:57:15]

felt@chromium.org changed reviewers:
+ jialiul@chromium.org

[commit-bot: I haz the power, 2017-05-22 22:57:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[felt, 2017-05-22 22:57:54]

jialiu, PTAL? Overdue cleanup on my part. :) BTW in addition to the file rename,
I made a one-line change to the CSS file because presubmit asked me to.

edwardjung FYI.

[commit-bot: I haz the power, 2017-05-22 23:09:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 23:09:47]

Dry run: This issue passed the CQ dry run.

[Jialiu Lin, 2017-05-23 02:18:48]

LGTM  Thanks for the clean up! :-)

[felt, 2017-05-23 02:31:40]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2017-05-23 02:32:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 02:42:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 02:42:11]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[felt, 2017-05-23 04:08:59]

felt@chromium.org changed reviewers:
+ edwardjung@chromium.org

[felt, 2017-05-23 04:10:07]

felt@chromium.org changed reviewers:
+ jochen@chromium.org

[felt, 2017-05-23 04:10:29]

edwardjung, can you actually pls review for the neterror change?

jochen, can you rubber stamp the grdp update?

[edwardjung, 2017-05-23 10:40:42]

Wonder if renaming everything to loud is the best thing. Since the CSS contains
styling for captive portal, ssl, etc which aren't 'loud'. 

At some point I should probably split the core common interstitial styles from
the variants styling. Maybe something like this:

+ interstitial_common.css - shared by all interstitials except the quiet one.
+ interstitial_core.css - renamed from current interstitial_common.css
+ interstitial_safebrowsing.css
+ interstitial_ssl.css
+ interstitial_captiveportal.css
+ interstitial_badclock.css

[jochen (gone - plz use gerrit), 2017-05-23 11:03:06]

as far as I can tell you're an owner for the grdp file?

[felt, 2017-05-23 16:01:30]

On 2017/05/23 10:40:42, edwardjung wrote:
> Wonder if renaming everything to loud is the best thing. Since the CSS
contains
> styling for captive portal, ssl, etc which aren't 'loud'.

We could go with "_large" instead, WDYT? 

> At some point I should probably split the core common interstitial styles from
> the variants styling. Maybe something like this:
> 
> + interstitial_common.css - shared by all interstitials except the quiet one.
> + interstitial_core.css - renamed from current interstitial_common.css
> + interstitial_safebrowsing.css
> + interstitial_ssl.css
> + interstitial_captiveportal.css
> + interstitial_badclock.css

Agreed, that would be a nice update.

[edwardjung, 2017-05-23 16:04:01]

> > Wonder if renaming everything to loud is the best thing. Since the CSS
> contains
> > styling for captive portal, ssl, etc which aren't 'loud'.
> 
> We could go with "_large" instead, WDYT?

SGTM

> 
> > At some point I should probably split the core common interstitial styles
from
> > the variants styling. Maybe something like this:
> > 
> > + interstitial_common.css - shared by all interstitials except the quiet
one.
> > + interstitial_core.css - renamed from current interstitial_common.css
> > + interstitial_safebrowsing.css
> > + interstitial_ssl.css
> > + interstitial_captiveportal.css
> > + interstitial_badclock.css
> 
> Agreed, that would be a nice update.

[felt, 2017-05-23 22:25:10]

Patchset #3 (id:40001) has been deleted

[felt, 2017-05-23 23:08:24]

The CQ bit was checked by felt@chromium.org to run a CQ dry run

[felt, 2017-05-23 23:08:31]

Did the rename.

https://codereview.chromium.org/2894413003/diff/20001/components/neterror/res...
File components/neterror/resources/neterror.html (right):

https://codereview.chromium.org/2894413003/diff/20001/components/neterror/res...
components/neterror/resources/neterror.html:11: <script
src="../../../components/security_interstitials/core/browser/resources/interstitial_loud_mobile.js"></script>
On 2017/05/23 10:21:25, edwardjung wrote:
> Does it makes sense to rename this. I see the JS here as shared UI code. Maybe
> something like interstitial_mobile_nav.js would be better? 

Done.

[commit-bot: I haz the power, 2017-05-23 23:09:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 23:21:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 23:21:35]

Dry run: This issue passed the CQ dry run.

[edwardjung, 2017-05-24 15:04:27]

lgtm

[felt, 2017-05-24 15:06:52]

The CQ bit was checked by felt@chromium.org

[felt, 2017-05-24 15:06:53]

The patchset sent to the CQ was uploaded after l-g-t-m from jialiul@chromium.org
Link to the patchset: https://codereview.chromium.org/2894413003/#ps80001
(title: "Missed a few spots")

[commit-bot: I haz the power, 2017-05-24 15:07:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 15:15:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 15:15:33]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jochen (gone - plz use gerrit), 2017-05-24 19:37:49]

lgtm

also created https://chromium-review.googlesource.com/514103

[felt, 2017-05-26 23:37:51]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2017-05-26 23:38:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 23:46:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 23:46:03]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[edwardjung, 2017-06-08 16:40:27]

@felt, do you want to submit this CL, then I can work on the reoganisation of
the CSS files. Thanks.

[felt, 2017-06-08 21:21:09]

The CQ bit was checked by felt@chromium.org

[felt, 2017-06-08 21:21:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
edwardjung@chromium.org, jochen@chromium.org, jialiul@chromium.org
Link to the patchset: https://codereview.chromium.org/2894413003/#ps120001
(title: "Fix rebase error")

[commit-bot: I haz the power, 2017-06-08 21:21:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 21:41:25]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1496956869681830,
"parent_rev": "7b99c95846da32cdb1060f59a1a1f5bd27ab2696", "commit_rev":
"5d92ae69ae7b36fe1b3cc15ee947aa811f635897"}

[commit-bot: I haz the power, 2017-06-08 21:41:37]

Description was changed from

==========
Rename interstitial_v2 files

1) I removed v1 a long time ago. It isn't relevant anymore that some
   files are v2.
2) This lets us differentiate between loud and quiet interstitials.
3) interstitial_ui.html was named confusingly (it is too similar to the
   others) so I gave it a more clear name.

BUG=
==========

to

==========
Rename interstitial_v2 files

1) I removed v1 a long time ago. It isn't relevant anymore that some
   files are v2.
2) This lets us differentiate between loud and quiet interstitials.
3) interstitial_ui.html was named confusingly (it is too similar to the
   others) so I gave it a more clear name.

BUG=

Review-Url: https://codereview.chromium.org/2894413003
Cr-Commit-Position: refs/heads/master@{#478096}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d92ae69ae7b36fe1b3cc15ee947...
==========

[commit-bot: I haz the power, 2017-06-08 21:41:40]

Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/5d92ae69ae7b36fe1b3cc15ee947...