[DeviceService] Move //device/nfc to be part of the internal impl of Device Service

Move //device/nfc to be part of the internal impl of Device Service

BUG=689501
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2894373002
Cr-Commit-Position: refs/heads/master@{#473822}
Committed: https://chromium.googlesource.com/chromium/src/+/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4

[leonhsl(Using Gerrit), 2017-05-21 06:59:31]

Description was changed from

==========
Move //device/nfc to be part of the internal impl of Device Service

BUG=689501
==========

to

==========
Move //device/nfc to be part of the internal impl of Device Service

BUG=689501
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[leonhsl(Using Gerrit), 2017-05-21 06:59:41]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-21 06:59:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-05-21 07:10:58]

Description was changed from

==========
Move //device/nfc to be part of the internal impl of Device Service

BUG=689501
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Move //device/nfc to be part of the internal impl of Device Service

BUG=689501
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2017-05-21 09:45:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-21 09:45:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[leonhsl(Using Gerrit), 2017-05-21 10:52:18]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-21 10:52:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-21 12:34:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-21 12:34:36]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2017-05-22 05:05:26]

leon.han@intel.com changed reviewers:
+ alexander.shalamov@intel.com, blundell@chromium.org, rockot@chromium.org

[leonhsl(Using Gerrit), 2017-05-22 05:05:28]

PTAL, Thanks!

blundell@chromium.org: Overall review and OWNERs of //services/device/

rockot@chromium.org: OWNERs of //device/

alexander.shalamov@intel.com: OWNERs of //third_party/WebKit/Source/modules/nfc/

[shalamov, 2017-05-22 08:00:46]

alexander.shalamov@intel.com changed reviewers:
+ reillyg@chromium.org

[shalamov, 2017-05-22 08:00:47]

third_party/WebKit/Source/modules/nfc/* lgtm
+Reilly

[blundell, 2017-05-22 09:21:36]

lgtm, thanks!

[leonhsl(Using Gerrit), 2017-05-22 12:08:54]

leon.han@intel.com changed reviewers:
+ jam@chromium.org, tsepez@chromium.org

[leonhsl(Using Gerrit), 2017-05-22 12:08:54]

+Tom for moving {nfc,nfc_provider}.mojom into
//services/device/public/interfaces/

+John for //content/, all changes are mechanical just because nfc files path
changed.

You could be comfortable to just give a RS ;-) Thanks!

[Tom Sepez, 2017-05-22 16:13:09]

RS on moving files.

[Tom Sepez, 2017-05-22 16:13:16]

lgtm

[Reilly Grant (use Gerrit), 2017-05-22 17:51:19]

lgtm

https://codereview.chromium.org/2894373002/diff/20001/content/public/android/...
File content/public/android/DEPS (right):

https://codereview.chromium.org/2894373002/diff/20001/content/public/android/...
content/public/android/DEPS:12: # Needed for ContentNfcDelegate.java
implementation.
This comment should probably remain generic like the one for //device above
because there likely will be more than one component of the device service
implemented in Java.

[jam, 2017-05-22 22:40:30]

lgtm

[leonhsl(Using Gerrit), 2017-05-23 00:26:11]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 00:27:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 03:29:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 03:29:44]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2017-05-23 06:28:30]

The CQ bit was checked by leon.han@intel.com

[leonhsl(Using Gerrit), 2017-05-23 06:28:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
reillyg@chromium.org, alexander.shalamov@intel.com, jam@chromium.org,
tsepez@chromium.org, blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/2894373002/#ps40001
(title: "Modify code comment")

[commit-bot: I haz the power, 2017-05-23 06:28:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 06:33:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495520910825500,
"parent_rev": "561da39a7a22b9d1ff96fcc742bd32bc2c3543b6", "commit_rev":
"02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4"}

[commit-bot: I haz the power, 2017-05-23 06:33:47]

Description was changed from

==========
Move //device/nfc to be part of the internal impl of Device Service

BUG=689501
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Move //device/nfc to be part of the internal impl of Device Service

BUG=689501
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2894373002
Cr-Commit-Position: refs/heads/master@{#473822}
Committed:
https://chromium.googlesource.com/chromium/src/+/02ed4aebda2b2da70a2c32a7b2b9...
==========

[commit-bot: I haz the power, 2017-05-23 06:33:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/02ed4aebda2b2da70a2c32a7b2b9...

[leonhsl(Using Gerrit), 2017-05-23 06:35:32]

https://codereview.chromium.org/2894373002/diff/20001/content/public/android/...
File content/public/android/DEPS (right):

https://codereview.chromium.org/2894373002/diff/20001/content/public/android/...
content/public/android/DEPS:12: # Needed for ContentNfcDelegate.java
implementation.
On 2017/05/22 17:51:19, Reilly Grant wrote:
> This comment should probably remain generic like the one for //device above
> because there likely will be more than one component of the device service
> implemented in Java.

Done.