Pass active_chrome_experiments in payments RPC.

Pass active_chrome_experiments in payments RPC.

BUG=

Review-Url: https://codereview.chromium.org/2894333002
Cr-Commit-Position: refs/heads/master@{#474001}
Committed: https://chromium.googlesource.com/chromium/src/+/ecc3d05879b07d9ed822b6b795872091d4e86b7b

[csashi, 2017-05-20 20:33:04]

csashi@google.com changed reviewers:
+ jsaul@google.com, sebsg@chromium.org

[csashi, 2017-05-20 20:33:04]

Hi,
Please take a look. Thanks!
-sashi.

[csashi, 2017-05-20 20:33:17]

The CQ bit was checked by csashi@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-20 20:33:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jared Saul, 2017-05-20 20:55:42]

lgtm

[csashi, 2017-05-20 20:57:27]

On 2017/05/20 20:55:42, Jared Saul wrote:
> lgtm

On 2nd thoughts, I think it would be better if I pass the flags only when the
experiment was triggered. - i.e. For example, if CVC was already detected in the
form - we don't want to set this flag unless we got the CVC because experiment
was enabled. Will send a follow-up. Sorry for the inconvenience.
-sashi.

[commit-bot: I haz the power, 2017-05-20 21:00:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-20 21:00:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mathieu, 2017-05-20 21:41:10]

On 2017/05/20 20:57:27, csashi wrote:
> On 2017/05/20 20:55:42, Jared Saul wrote:
> > lgtm
> 
> On 2nd thoughts, I think it would be better if I pass the flags only when the
> experiment was triggered. - i.e. For example, if CVC was already detected in
the
> form - we don't want to set this flag unless we got the CVC because experiment
> was enabled. Will send a follow-up. Sorry for the inconvenience.
> -sashi.

Have you looked into Variations headers? See autofill_download_manager. It will
send active Finch experiments.

[csashi, 2017-05-20 23:13:50]

On 2017/05/20 21:41:10, Mathieu wrote:
> On 2017/05/20 20:57:27, csashi wrote:
> > On 2017/05/20 20:55:42, Jared Saul wrote:
> > > lgtm
> > 
> > On 2nd thoughts, I think it would be better if I pass the flags only when
the
> > experiment was triggered. - i.e. For example, if CVC was already detected in
> the
> > form - we don't want to set this flag unless we got the CVC because
experiment
> > was enabled. Will send a follow-up. Sorry for the inconvenience.
> > -sashi.
> 
> Have you looked into Variations headers? See autofill_download_manager. It
will
> send active Finch experiments.

Hi Mathieu,
Thanks for the pointer to variations headers. I was not aware of these headers.

Assuming that these headers are passed through to the payments server, we can
use them. However, please see my latest patch. It is better if we tell the
server that a feature was triggered - i.e. we want to ignore features that were
enabled but did not impact the RPC.
-sashi.

[csashi, 2017-05-20 23:17:11]

The CQ bit was checked by csashi@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-20 23:17:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-21 00:46:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-21 00:46:17]

Dry run: This issue passed the CQ dry run.

[Jared Saul, 2017-05-23 00:15:28]

lgtm

[sebsg, 2017-05-23 13:27:21]

Yeah, I like your second patch better, Only send it when it affected the result.


LGTM :)

[csashi, 2017-05-23 16:27:52]

The CQ bit was checked by csashi@google.com

[commit-bot: I haz the power, 2017-05-23 16:28:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 18:50:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495556872228200,
"parent_rev": "fb7da5949a9529ba0b63ab06e76cd4a8c351db26", "commit_rev":
"ecc3d05879b07d9ed822b6b795872091d4e86b7b"}

[commit-bot: I haz the power, 2017-05-23 18:50:40]

Description was changed from

==========
Pass active_chrome_experiments in payments RPC.

BUG=
==========

to

==========
Pass active_chrome_experiments in payments RPC.

BUG=

Review-Url: https://codereview.chromium.org/2894333002
Cr-Commit-Position: refs/heads/master@{#474001}
Committed:
https://chromium.googlesource.com/chromium/src/+/ecc3d05879b07d9ed822b6b79587...
==========

[commit-bot: I haz the power, 2017-05-23 18:50:41]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ecc3d05879b07d9ed822b6b79587...