Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2894243004: Print Preview tests: Remove unnecessary C++ class definition (Closed)

Created:
3 years, 7 months ago by rbpotter
Modified:
3 years, 7 months ago
Reviewers:
dpapad
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Print Preview tests: Remove unnecessary C++ class definition It is no longer necessary to manually define a C++ class for PrintPreviewWebUITest as it can be autogenerated, so chrome/test/data/webui/print_preview.cc and .h are no longer needed. Remove these extra files and references to them. BUG=None Review-Url: https://codereview.chromium.org/2894243004 Cr-Commit-Position: refs/heads/master@{#473616} Committed: https://chromium.googlesource.com/chromium/src/+/32600d88e079e01b8f6f67b10db4f548dedc54b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -45 lines) Patch
M chrome/test/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
D chrome/test/data/webui/print_preview.h View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/webui/print_preview.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/test/data/webui/print_preview.js View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
rbpotter
3 years, 7 months ago (2017-05-19 23:08:44 UTC) #5
dpapad
LGTM. To be a bit more accurate I would mention that manually defining a PrintPreviewWebUITest ...
3 years, 7 months ago (2017-05-19 23:18:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894243004/1
3 years, 7 months ago (2017-05-22 16:47:21 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 17:52:42 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/32600d88e079e01b8f6f67b10db4...

Powered by Google App Engine
This is Rietveld 408576698