Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2894243003: [ios clean] ToolbarButton tint color changes. (Closed)

Created:
3 years, 7 months ago by sczs
Modified:
3 years, 7 months ago
Reviewers:
edchin
CC:
chromium-reviews, marq+scrutinize_chromium.org, lpromero+watch_chromium.org, ios-reviews+clean_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios clean] ToolbarButton tint color changes. -Buttons were SystemType and for this reason their images tint color was off. -Fixed images and Added new ToolbarButtons. BUG=683793 Review-Url: https://codereview.chromium.org/2894243003 Cr-Commit-Position: refs/heads/master@{#473321} Committed: https://chromium.googlesource.com/chromium/src/+/358a51668eeafb221967c773e5beaf006ef5abab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M ios/clean/chrome/browser/ui/toolbar/toolbar_button.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/toolbar/toolbar_button+factory.mm View 3 chunks +21 lines, -8 lines 0 comments Download
M ios/clean/chrome/browser/ui/toolbar/toolbar_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/toolbar/toolbar_constants.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
sczs
PTAL Ed, it should be quick :)
3 years, 7 months ago (2017-05-19 20:18:44 UTC) #3
edchin
lgtm
3 years, 7 months ago (2017-05-19 20:59:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894243003/1
3 years, 7 months ago (2017-05-19 21:04:12 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 21:20:10 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/358a51668eeafb221967c773e5be...

Powered by Google App Engine
This is Rietveld 408576698