Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 2894183002: Local declarations take precedence over exports. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M pkg/front_end/lib/src/fasta/builder/library_builder.dart View 1 chunk +5 lines, -0 lines 2 comments Download
M pkg/front_end/test/incremental_kernel_generator_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
scheglov
3 years, 7 months ago (2017-05-19 18:12:15 UTC) #1
Siggi Cherem (dart-lang)
I'm not familiar enough yet with the library builder - Paul or Peter can you ...
3 years, 7 months ago (2017-05-19 18:19:24 UTC) #2
Paul Berry
lgtm
3 years, 7 months ago (2017-05-20 13:47:12 UTC) #3
scheglov
Committed patchset #1 (id:1) manually as d7be9e36e8117f448eef47914b901023b74612b4 (presubmit successful).
3 years, 7 months ago (2017-05-21 01:36:02 UTC) #5
ahe
https://codereview.chromium.org/2894183002/diff/1/pkg/front_end/lib/src/fasta/builder/library_builder.dart File pkg/front_end/lib/src/fasta/builder/library_builder.dart (right): https://codereview.chromium.org/2894183002/diff/1/pkg/front_end/lib/src/fasta/builder/library_builder.dart#newcode104 pkg/front_end/lib/src/fasta/builder/library_builder.dart:104: if (existing.parent == this) return false; buildAmbiguousBuilder should take ...
3 years, 7 months ago (2017-05-22 11:39:45 UTC) #6
scheglov
3 years, 7 months ago (2017-05-22 18:35:24 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/2894183002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/builder/library_builder.dart (right):

https://codereview.chromium.org/2894183002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/builder/library_builder.dart:104: if
(existing.parent == this) return false;
On 2017/05/22 11:39:45, ahe wrote:
> buildAmbiguousBuilder should take care of this.

Ah, I see now.
https://codereview.chromium.org/2893383002

Powered by Google App Engine
This is Rietveld 408576698