Issue 2893383002: Move the check for 'locals hides exports' to DillLibraryBuilder.buildAmbiguousBuilder().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2893383002: Move the check for 'locals hides exports' to DillLibraryBuilder.buildAmbiguousBuilder(). (Closed)

Created:
3 years, 7 months ago by scheglov

Modified:
3 years, 7 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Move the check for 'locals hides exports' to DillLibraryBuilder.buildAmbiguousBuilder(). R=ahe@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5139a1f85cb96ed319f9b8e5c86daa995c8dd4e8

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	pkg/front_end/lib/src/fasta/builder/library_builder.dart	View		1 chunk	+0 lines, -5 lines	0 comments	Download
	M	pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 7 months ago (2017-05-22 20:07:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5139a1f85cb96ed319f9b8e5c86daa995c8dd4e8 (presubmit successful).