[Payments] Only send schemeless origin to Android native payment apps

Only send schemeless origin to Android native payment apps

Only Android native payment apps accept schemeless origin for history reason.
Service worker based payment apps request full origin.

BUG=720027
Review-Url: https://codereview.chromium.org/2894153003
Cr-Commit-Position: refs/heads/master@{#473907}
Committed: https://chromium.googlesource.com/chromium/src/+/ec5db40750a7241b6615f21734e6cd9c34fe42e3

[gogerald1, 2017-05-19 21:00:49]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[gogerald1, 2017-05-19 21:01:13]

Description was changed from

==========
Only send schemeless origin to Android native payment apps

BUG=
==========

to

==========
Only send schemeless origin to Android native payment apps

BUG=
==========

[gogerald1, 2017-05-19 21:02:43]

Description was changed from

==========
Only send schemeless origin to Android native payment apps

BUG=
==========

to

==========
Only send schemeless origin to Android native payment apps

Only Android native payment apps accept schemeless origin for history reason.
Service worker based payment app request full origin.

BUG=720027
==========

[commit-bot: I haz the power, 2017-05-19 21:03:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2017-05-19 21:07:13]

gogerald@chromium.org changed reviewers:
+ rouslan@chromium.org

[gogerald1, 2017-05-19 21:07:14]

Hi rouslan@, PTAL,

[gogerald1, 2017-05-19 21:32:24]

Description was changed from

==========
Only send schemeless origin to Android native payment apps

Only Android native payment apps accept schemeless origin for history reason.
Service worker based payment app request full origin.

BUG=720027
==========

to

==========
Only send schemeless origin to Android native payment apps

Only Android native payment apps accept schemeless origin for history reason.
Service worker based payment apps request full origin.

BUG=720027
==========

[commit-bot: I haz the power, 2017-05-19 22:12:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 22:12:18]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-05-22 13:47:55]

https://codereview.chromium.org/2894153003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
(right):

https://codereview.chromium.org/2894153003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:171:
UrlFormatter.formatUrlForSecurityDisplay(
Create a private static method to remove scheme from an origin. That would make
reading this code easier.

private static String removeScheme(String origin) {
  return UrlFormatter.formatUrlForSecurityDisplay(
      origin, false /* omit scheme */ );
}

mIsReadyToPayIntent.putExtras(buildExtras(null /* id */, null, /* merchantName
*/, removeScheme(origin), removeScheme(iframeOrigin), ...

[gogerald1, 2017-05-23 12:20:24]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 12:20:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2017-05-23 13:10:16]

addressed the comment, another look?

https://codereview.chromium.org/2894153003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
(right):

https://codereview.chromium.org/2894153003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:171:
UrlFormatter.formatUrlForSecurityDisplay(
On 2017/05/22 13:47:55, ಠ_ಠ wrote:
> Create a private static method to remove scheme from an origin. That would
make
> reading this code easier.
> 
> private static String removeScheme(String origin) {
>   return UrlFormatter.formatUrlForSecurityDisplay(
>       origin, false /* omit scheme */ );
> }
> 
> mIsReadyToPayIntent.putExtras(buildExtras(null /* id */, null, /* merchantName
> */, removeScheme(origin), removeScheme(iframeOrigin), ...

Done.

[commit-bot: I haz the power, 2017-05-23 13:10:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 13:10:55]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-05-23 13:14:23]

lgtm

lgtm % comment

https://codereview.chromium.org/2894153003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
(right):

https://codereview.chromium.org/2894153003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:268:
public void invokePaymentApp(final String id, final String merchantName, final
String origin,
Remove "final" from "origin" and "iframeOrigin".

[gogerald1, 2017-05-23 14:14:32]

Thanks, sending to CQ soon

https://codereview.chromium.org/2894153003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
(right):

https://codereview.chromium.org/2894153003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:268:
public void invokePaymentApp(final String id, final String merchantName, final
String origin,
On 2017/05/23 13:14:22, ಠ_ಠ wrote:
> Remove "final" from "origin" and "iframeOrigin".

Done.

[gogerald1, 2017-05-23 14:14:37]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 14:14:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 14:59:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 14:59:45]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2017-05-23 15:17:38]

The CQ bit was checked by gogerald@chromium.org

[gogerald1, 2017-05-23 15:17:39]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2894153003/#ps40001
(title: "remove unnecessary 'final'")

[commit-bot: I haz the power, 2017-05-23 15:18:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 15:22:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495552658001850,
"parent_rev": "0a15ffb1835a5e36e3941fb0c71f23960a6d5e6e", "commit_rev":
"ec5db40750a7241b6615f21734e6cd9c34fe42e3"}

[commit-bot: I haz the power, 2017-05-23 15:23:03]

Description was changed from

==========
Only send schemeless origin to Android native payment apps

Only Android native payment apps accept schemeless origin for history reason.
Service worker based payment apps request full origin.

BUG=720027
==========

to

==========
Only send schemeless origin to Android native payment apps

Only Android native payment apps accept schemeless origin for history reason.
Service worker based payment apps request full origin.

BUG=720027

Review-Url: https://codereview.chromium.org/2894153003
Cr-Commit-Position: refs/heads/master@{#473907}
Committed:
https://chromium.googlesource.com/chromium/src/+/ec5db40750a7241b6615f21734e6...
==========

[commit-bot: I haz the power, 2017-05-23 15:23:04]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ec5db40750a7241b6615f21734e6...