|
|
DescriptionAdd //third_party/boringssl as a public dep of //net
net/cert/x509_certificate.h uses 'openssl/is_boringssl.h'
BUG=internal b/37998486
TEST=Build
Review-Url: https://codereview.chromium.org/2894093004
Cr-Commit-Position: refs/heads/master@{#479220}
Committed: https://chromium.googlesource.com/chromium/src/+/d0b70c4e593e51e13aa4222cbd683c643587017d
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
Description was changed from ========== Add //third_party/boringssl as a public dep of //net net/cert/x509_certificate.h uses 'openssl/is_boringssl.h' BUG=internal b/37998486 TEST=Build ========== to ========== Add //third_party/boringssl as a public dep of //net net/cert/x509_certificate.h uses 'openssl/is_boringssl.h' BUG=internal b/37998486 TEST=Build ==========
bcf@chromium.org changed reviewers: + davidben@chromium.org, mattm@chromium.org
Followup to https://codereview.chromium.org/2888763005/ Will just create a public_deps chain as discussed.
lgtm, but this isn't necessary to fix your bug. //crypto:platform is a weird legacy alias to //third_party/boringssl (except it also pulls in system NSS when we need it). They're merged together as a remnant of when we had to switch support both NSS and OpenSSL/BoringSSL for crypto bits, and now they're more orthogonal. I still haven't gotten around to splitting that back up. :-( But adding this explicitly seems sensible enough. I'll see if I can clean this up more coherently.
The CQ bit was checked by bcf@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by bcf@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bcf@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1497398812716310, "parent_rev": "23fe0e721faec0123be8c521e377ff22c7fefe88", "commit_rev": "d0b70c4e593e51e13aa4222cbd683c643587017d"}
Message was sent while issue was closed.
Description was changed from ========== Add //third_party/boringssl as a public dep of //net net/cert/x509_certificate.h uses 'openssl/is_boringssl.h' BUG=internal b/37998486 TEST=Build ========== to ========== Add //third_party/boringssl as a public dep of //net net/cert/x509_certificate.h uses 'openssl/is_boringssl.h' BUG=internal b/37998486 TEST=Build Review-Url: https://codereview.chromium.org/2894093004 Cr-Commit-Position: refs/heads/master@{#479220} Committed: https://chromium.googlesource.com/chromium/src/+/d0b70c4e593e51e13aa4222cbd68... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d0b70c4e593e51e13aa4222cbd68... |