Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2894093004: Add //third_party/boringssl as a public dep of //net

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 days, 15 hours ago by bcf
Modified:
4 days, 15 hours ago
Reviewers:
davidben, mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add //third_party/boringssl as a public dep of //net net/cert/x509_certificate.h uses 'openssl/is_boringssl.h' BUG=internal b/37998486 TEST=Build

Patch Set 1 #

Messages

Total messages: 8 (4 generated)
bcf
Followup to https://codereview.chromium.org/2888763005/ Will just create a public_deps chain as discussed.
5 days, 15 hours ago (2017-05-19 02:19:45 UTC) #3
davidben
lgtm, but this isn't necessary to fix your bug. //crypto:platform is a weird legacy alias ...
5 days, 2 hours ago (2017-05-19 15:43:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894093004/1
4 days, 17 hours ago (2017-05-20 00:23:07 UTC) #6
commit-bot: I haz the power
4 days, 15 hours ago (2017-05-20 02:17:33 UTC) #8
Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06