third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp - Issue 2894093002: Don't access DisplayItemClient::VisualRect() for cached display items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp

Issue 2894093002: Don't access DisplayItemClient::VisualRect() for cached display items. (Closed)

Patch Set: - Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h ('k') | third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItemTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp

index 55b511afd347582d99c8248b02ad966d5c3b2230..9706eef1d92d1e52122197a5161e1d93f8893aee 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp

@@ -19,10 +19,14 @@ void DrawingDisplayItem::Replay(GraphicsContext& context) const {

}

void DrawingDisplayItem::AppendToWebDisplayItemList(

- const IntRect& visual_rect,

+ const LayoutSize& visual_rect_offset,

WebDisplayItemList* list) const {

- if (record_)

- list->AppendDrawingItem(visual_rect, record_);

+ if (record_) {

+ // Convert visual rect into the GraphicsLayer's coordinate space.

+ LayoutRect visual_rect = VisualRect();

+ visual_rect.Move(-visual_rect_offset);

+ list->AppendDrawingItem(EnclosingIntRect(visual_rect), record_);

+ }

}

bool DrawingDisplayItem::DrawsContent() const {