Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp

Issue 2894093002: Don't access DisplayItemClient::VisualRect() for cached display items. (Closed)
Patch Set: - Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/graphics/paint/DrawingDisplayItem.h" 5 #include "platform/graphics/paint/DrawingDisplayItem.h"
6 6
7 #include "platform/graphics/GraphicsContext.h" 7 #include "platform/graphics/GraphicsContext.h"
8 #include "platform/graphics/paint/PaintCanvas.h" 8 #include "platform/graphics/paint/PaintCanvas.h"
9 #include "public/platform/WebDisplayItemList.h" 9 #include "public/platform/WebDisplayItemList.h"
10 #include "third_party/skia/include/core/SkBitmap.h" 10 #include "third_party/skia/include/core/SkBitmap.h"
11 #include "third_party/skia/include/core/SkCanvas.h" 11 #include "third_party/skia/include/core/SkCanvas.h"
12 #include "third_party/skia/include/core/SkData.h" 12 #include "third_party/skia/include/core/SkData.h"
13 13
14 namespace blink { 14 namespace blink {
15 15
16 void DrawingDisplayItem::Replay(GraphicsContext& context) const { 16 void DrawingDisplayItem::Replay(GraphicsContext& context) const {
17 if (record_) 17 if (record_)
18 context.DrawRecord(record_); 18 context.DrawRecord(record_);
19 } 19 }
20 20
21 void DrawingDisplayItem::AppendToWebDisplayItemList( 21 void DrawingDisplayItem::AppendToWebDisplayItemList(
22 const IntRect& visual_rect, 22 const LayoutSize& visual_rect_offset,
23 WebDisplayItemList* list) const { 23 WebDisplayItemList* list) const {
24 if (record_) 24 if (record_) {
25 list->AppendDrawingItem(visual_rect, record_); 25 // Convert visual rect into the GraphicsLayer's coordinate space.
26 LayoutRect visual_rect = VisualRect();
27 visual_rect.Move(-visual_rect_offset);
28 list->AppendDrawingItem(EnclosingIntRect(visual_rect), record_);
29 }
26 } 30 }
27 31
28 bool DrawingDisplayItem::DrawsContent() const { 32 bool DrawingDisplayItem::DrawsContent() const {
29 return record_.get(); 33 return record_.get();
30 } 34 }
31 35
32 int DrawingDisplayItem::NumberOfSlowPaths() const { 36 int DrawingDisplayItem::NumberOfSlowPaths() const {
33 return record_ ? record_->numSlowPaths() : 0; 37 return record_ ? record_->numSlowPaths() : 0;
34 } 38 }
35 39
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 111
108 if (RecordsEqual(record, other_record)) 112 if (RecordsEqual(record, other_record))
109 return true; 113 return true;
110 114
111 // Sometimes the client may produce different records for the same visual 115 // Sometimes the client may produce different records for the same visual
112 // result, which should be treated as equal. 116 // result, which should be treated as equal.
113 return BitmapsEqual(std::move(record), std::move(other_record)); 117 return BitmapsEqual(std::move(record), std::move(other_record));
114 } 118 }
115 119
116 } // namespace blink 120 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698