Prevent real IME from interfering with UrlBarTest

Prevent real IME from interfering with UrlBarTest

Android framework does not provide an easy way to remove keyboard app
from the testing (unless you use Robolectric).

So far we have been allowing the current keyboard app to interfere with
test and thus flaked test results. Especially, when you make selection
change, Google Latin Keyboard tries to look at the new status by running

beginBatchEdit() -> getTextBeforeCursor() -> endBatchEdit().

And this disrupted batch edit logic such as mInBatchEditMode.

With this change, onCreateInputConnection() will now return null, so
keyboard app cannot interact with the text. Also, dispatchKeyEvent
will ignore key events when it has to.

Note that the test can still interact with BaseInputConnection's method
and thus affects EditText's Editable through UrlBar#getInputConnection().

In doing so, I've guarded KeyUtils#dispatchKeyEventToView() to work with
UI thread.

BUG=723901
Review-Url: https://codereview.chromium.org/2894073002
Cr-Commit-Position: refs/heads/master@{#473782}
Committed: https://chromium.googlesource.com/chromium/src/+/bae36d8062ad39d994cdf27a99418ec3fbe5aa13

[Changwan Ryu, 2017-05-18 22:15:23]

The CQ bit was checked by changwan@chromium.org to run a CQ dry run

[Changwan Ryu, 2017-05-18 22:15:55]

changwan@chromium.org changed reviewers:
+ tedchoc@chromium.org

[commit-bot: I haz the power, 2017-05-18 22:17:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 00:17:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 00:17:46]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-05-23 00:04:49]

lgtm

[Changwan Ryu, 2017-05-23 00:07:17]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2017-05-23 00:08:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 02:00:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495498037037790, "parent_rev":
"43417886667f8c68d74056371a61845cdaddd4a9", "commit_rev":
"bae36d8062ad39d994cdf27a99418ec3fbe5aa13"}

[commit-bot: I haz the power, 2017-05-23 02:00:53]

Description was changed from

==========
Prevent real IME from interfering with UrlBarTest

Android framework does not provide an easy way to remove keyboard app
from the testing (unless you use Robolectric).

So far we have been allowing the current keyboard app to interfere with
test and thus flaked test results. Especially, when you make selection
change, Google Latin Keyboard tries to look at the new status by running

beginBatchEdit() -> getTextBeforeCursor() -> endBatchEdit().

And this disrupted batch edit logic such as mInBatchEditMode.

With this change, onCreateInputConnection() will now return null, so
keyboard app cannot interact with the text. Also, dispatchKeyEvent
will ignore key events when it has to.

Note that the test can still interact with BaseInputConnection's method
and thus affects EditText's Editable through UrlBar#getInputConnection().

In doing so, I've guarded KeyUtils#dispatchKeyEventToView() to work with
UI thread.

BUG=723901
==========

to

==========
Prevent real IME from interfering with UrlBarTest

Android framework does not provide an easy way to remove keyboard app
from the testing (unless you use Robolectric).

So far we have been allowing the current keyboard app to interfere with
test and thus flaked test results. Especially, when you make selection
change, Google Latin Keyboard tries to look at the new status by running

beginBatchEdit() -> getTextBeforeCursor() -> endBatchEdit().

And this disrupted batch edit logic such as mInBatchEditMode.

With this change, onCreateInputConnection() will now return null, so
keyboard app cannot interact with the text. Also, dispatchKeyEvent
will ignore key events when it has to.

Note that the test can still interact with BaseInputConnection's method
and thus affects EditText's Editable through UrlBar#getInputConnection().

In doing so, I've guarded KeyUtils#dispatchKeyEventToView() to work with
UI thread.

BUG=723901

Review-Url: https://codereview.chromium.org/2894073002
Cr-Commit-Position: refs/heads/master@{#473782}
Committed:
https://chromium.googlesource.com/chromium/src/+/bae36d8062ad39d994cdf27a9941...
==========

[commit-bot: I haz the power, 2017-05-23 02:00:57]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bae36d8062ad39d994cdf27a9941...