Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2894013003:
Replace sanitizers:deps with exe_and_shlib_deps (v8) (Closed)
|
Created:
3 years, 7 months ago by Tom Anderson Modified:
3 years, 7 months ago CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org Target Ref:
refs/heads/master Project:
v8 Visibility:
Public. |
DescriptionReplace sanitizers:deps with exe_and_shlib_deps (v8)
All targets (at least on sanitizer builds) unconditionally depend
on //build/config/sanitizers:deps.
It is necessary for bug 593874 that all targets now also depend
on //buildtools/third_party/libc++:libcxx_proxy. This requires
adding a new "global dependency": //build/config:exe_and_shlib_deps.
This CL updates references to sanitizers:deps to instead refer to
//build/config:exe_and_shlib_deps.
BUG=chromium:723069
R=bradnelson@chromium.org
Review-Url: https://codereview.chromium.org/2894013003
Cr-Commit-Position: refs/heads/master@{#45435}
Committed: https://chromium.googlesource.com/v8/v8/+/cb7dd0a911adf91afbe9ebae3df84b56756087d3
Patch Set 1 #Patch Set 2 : Rebase #
Messages
Total messages: 33 (27 generated)
Description was changed from ========== Replace sanitizers:deps with exe_and_shlib_deps BUG=676220 ========== to ========== Replace sanitizers:deps with exe_and_shlib_deps BUG=676220 R=bradnelson@chromium.org ==========
Description was changed from ========== Replace sanitizers:deps with exe_and_shlib_deps BUG=676220 R=bradnelson@chromium.org ========== to ========== Replace sanitizers:deps with exe_and_shlib_deps (v8) BUG=676220 R=bradnelson@chromium.org ==========
thomasanderson@chromium.org changed reviewers: + bradnelson@chromium.org
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/41406)
Description was changed from ========== Replace sanitizers:deps with exe_and_shlib_deps (v8) BUG=676220 R=bradnelson@chromium.org ========== to ========== Replace sanitizers:deps with exe_and_shlib_deps (v8) BUG=chromium:676220 R=bradnelson@chromium.org ==========
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Replace sanitizers:deps with exe_and_shlib_deps (v8) BUG=chromium:676220 R=bradnelson@chromium.org ========== to ========== Replace sanitizers:deps with exe_and_shlib_deps (v8) BUG=chromium:723069 R=bradnelson@chromium.org ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thomasanderson@chromium.org changed reviewers: + adamk@chromium.org, ahaas@chromium.org, bbudge@chromium.org, binji@chromium.org
+additional v8 OWNERS
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/41510)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm (based on my reading of the attached bug; a bit of detail in the CL description would've been useful in reviewing this).
Description was changed from ========== Replace sanitizers:deps with exe_and_shlib_deps (v8) BUG=chromium:723069 R=bradnelson@chromium.org ========== to ========== Replace sanitizers:deps with exe_and_shlib_deps (v8) All targets (at least on sanitizer builds) unconditionally depend on //build/config/sanitizers:deps. It is necessary for bug 593874 that all targets now also depend on //buildtools/third_party/libc++:libcxx_proxy. This requires adding a new "global dependency": //build/config:exe_and_shlib_deps. This CL updates references to sanitizers:deps to instead refer to //build/config:exe_and_shlib_deps. BUG=chromium:723069 R=bradnelson@chromium.org ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/05/19 21:28:03, adamk wrote: > lgtm (based on my reading of the attached bug; a bit of detail in the CL > description would've been useful in reviewing this). done :)
The CQ bit was checked by thomasanderson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Replace sanitizers:deps with exe_and_shlib_deps (v8) All targets (at least on sanitizer builds) unconditionally depend on //build/config/sanitizers:deps. It is necessary for bug 593874 that all targets now also depend on //buildtools/third_party/libc++:libcxx_proxy. This requires adding a new "global dependency": //build/config:exe_and_shlib_deps. This CL updates references to sanitizers:deps to instead refer to //build/config:exe_and_shlib_deps. BUG=chromium:723069 R=bradnelson@chromium.org ========== to ========== Replace sanitizers:deps with exe_and_shlib_deps (v8) All targets (at least on sanitizer builds) unconditionally depend on //build/config/sanitizers:deps. It is necessary for bug 593874 that all targets now also depend on //buildtools/third_party/libc++:libcxx_proxy. This requires adding a new "global dependency": //build/config:exe_and_shlib_deps. This CL updates references to sanitizers:deps to instead refer to //build/config:exe_and_shlib_deps. BUG=chromium:723069 R=bradnelson@chromium.org ==========
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495230672018710,
"parent_rev": "c476e8afc1dfe9245c85d3ee150d206ff86fee3b", "commit_rev":
"cb7dd0a911adf91afbe9ebae3df84b56756087d3"}
Message was sent while issue was closed.
Description was changed from ========== Replace sanitizers:deps with exe_and_shlib_deps (v8) All targets (at least on sanitizer builds) unconditionally depend on //build/config/sanitizers:deps. It is necessary for bug 593874 that all targets now also depend on //buildtools/third_party/libc++:libcxx_proxy. This requires adding a new "global dependency": //build/config:exe_and_shlib_deps. This CL updates references to sanitizers:deps to instead refer to //build/config:exe_and_shlib_deps. BUG=chromium:723069 R=bradnelson@chromium.org ========== to ========== Replace sanitizers:deps with exe_and_shlib_deps (v8) All targets (at least on sanitizer builds) unconditionally depend on //build/config/sanitizers:deps. It is necessary for bug 593874 that all targets now also depend on //buildtools/third_party/libc++:libcxx_proxy. This requires adding a new "global dependency": //build/config:exe_and_shlib_deps. This CL updates references to sanitizers:deps to instead refer to //build/config:exe_and_shlib_deps. BUG=chromium:723069 R=bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2894013003 Cr-Commit-Position: refs/heads/master@{#45435} Committed: https://chromium.googlesource.com/v8/v8/+/cb7dd0a911adf91afbe9ebae3df84b56756... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/cb7dd0a911adf91afbe9ebae3df84b56756... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
