Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2894003003: [merge to m59]md settings: Fix dialog buttons on lock screen. (Closed)

Created:
3 years, 7 months ago by sammiequon
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[merge to m59]md settings: Fix dialog buttons on lock screen. Fix the password prompt, pin setup, fingerprint setup dialogs on the lock screen. They dont use the 'button-container' class from cr-dialog, so they are missing some margins/paddings the other dialogs have. Also the previous 'button-strip' was part of the body content of cr-dialog. Before: https://screenshot.googleplex.com/heBMZLNjZXY After: https://screenshot.googleplex.com/TYHdxUQNzC6 TEST=manual BUG=723192 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2889893002 Cr-Original-Commit-Position: refs/heads/master@{#472586} Review-Url: https://codereview.chromium.org/2894003003 . Cr-Commit-Position: refs/branch-heads/3071@{#620} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/b2ba5f2a226750292f28fe300c8ba4c845fa34df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -32 lines) Patch
M chrome/browser/resources/settings/people_page/password_prompt_dialog.html View 1 chunk +9 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html View 1 chunk +10 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/people_page/setup_pin_dialog.html View 1 chunk +9 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sammiequon
3 years, 7 months ago (2017-05-18 19:41:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b2ba5f2a226750292f28fe300c8ba4c845fa34df.

Powered by Google App Engine
This is Rietveld 408576698