Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1501)

Issue 2893903002: [Password Generation] Set TYPE_GENERATED to presaved credentials (Closed)

Created:
3 years, 7 months ago by kolos1
Modified:
3 years, 7 months ago
Reviewers:
dvadym
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Generation] Set TYPE_GENERATED to presaved credentials Since a user accepts a password generated by Chrome, the password is presaved to the store. |PasswordForm.type| should be set to TYPE_GENERATED. This CL implements that. It is important for metrics. BUG=None Review-Url: https://codereview.chromium.org/2893903002 Cr-Commit-Position: refs/heads/master@{#472805} Committed: https://chromium.googlesource.com/chromium/src/+/659da7906d9027de3e9eb0a436ea92b586e1f5d8

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/renderer/autofill/fake_content_password_manager_driver.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/password_generation_agent.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
kolos1
3 years, 7 months ago (2017-05-18 13:28:11 UTC) #4
dvadym
On 2017/05/18 13:28:11, kolos1 wrote: LGTM
3 years, 7 months ago (2017-05-18 13:32:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893903002/20001
3 years, 7 months ago (2017-05-18 13:34:26 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 14:55:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/659da7906d9027de3e9eb0a436ea...

Powered by Google App Engine
This is Rietveld 408576698