Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2893853003: Revert of Use Stub CDM for building libwidevinecdmadapter.so (Closed)

Created:
3 years, 7 months ago by Haoming Chen
Modified:
3 years, 7 months ago
Reviewers:
xhwang, hmchen1
CC:
chromium-reviews, eme-reviews_chromium.org, tinskip1, krasin1, Rintaro Kuroiwa, jrummell
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use Stub CDM for building libwidevinecdmadapter.so (patchset #4 id:100001 of https://codereview.chromium.org/2792743002/ ) Reason for revert: Using stub cdm is a workaround and it breaks the load_library_perf_test. This change reverts the stub cdm because the unaligned ELF header issue has been fixed for libwidevinecdm.so, so that we can re-enable the load_library_perf_test. Original issue's description: > Use Stub CDM for building libwidevinecdmadapter.so > > - This is a temporary fix for unblocking LLD. > - We use the stub CDM to build the CDM adapter. > - We ship the copied (real) CDM and the CDM adapter. > - Even though the CDM adapter is built against the stub cdm at > "stub_cdm/libwidevinecdm.so", only the filename is baked > into the adapter because of the gn dependency, > e.g., readelf -d libwidevinecdmadapter.so : > 0x0000000000000001 (NEEDED) Shared library: [libwidevinecdm.so] > - At run time, when loading the CDM adapter, the system will search > for the CDM in the same dir where the adapter is located. Hence > the real CDM will be loaded. > > BUG=707488 > > Review-Url: https://codereview.chromium.org/2792743002 > Cr-Commit-Position: refs/heads/master@{#462104} > Committed: https://chromium.googlesource.com/chromium/src/+/4bd7678fefa459f3f29a4ea511ff26971cfb5648 TBR=xhwang@chromium.org,hmchen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=707488 Review-Url: https://codereview.chromium.org/2893853003 Cr-Commit-Position: refs/heads/master@{#473408} Committed: https://chromium.googlesource.com/chromium/src/+/d07d1d29fc7cda26a10b4d1283d1af86aae9a755

Patch Set 1 #

Patch Set 2 : Rebase and resolve conflicts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -45 lines) Patch
M third_party/widevine/cdm/BUILD.gn View 1 3 chunks +2 lines, -45 lines 0 comments Download

Messages

Total messages: 30 (13 generated)
Haoming Chen
Created Revert of Use Stub CDM for building libwidevinecdmadapter.so
3 years, 7 months ago (2017-05-18 17:26:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893853003/1
3 years, 7 months ago (2017-05-18 17:27:50 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-18 17:27:52 UTC) #5
xhwang
lgtm
3 years, 7 months ago (2017-05-18 17:38:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893853003/1
3 years, 7 months ago (2017-05-18 18:00:07 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/430793)
3 years, 7 months ago (2017-05-18 20:45:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893853003/1
3 years, 7 months ago (2017-05-18 21:45:17 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/431089)
3 years, 7 months ago (2017-05-18 23:56:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893853003/1
3 years, 7 months ago (2017-05-19 05:51:21 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/442118)
3 years, 7 months ago (2017-05-19 06:00:21 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893853003/1
3 years, 7 months ago (2017-05-19 17:02:28 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/442544)
3 years, 7 months ago (2017-05-19 17:10:59 UTC) #22
xhwang
On 2017/05/19 17:10:59, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 7 months ago (2017-05-19 21:12:15 UTC) #23
hmchen1
On 2017/05/19 21:12:15, xhwang wrote: > On 2017/05/19 17:10:59, commit-bot: I haz the power wrote: ...
3 years, 7 months ago (2017-05-19 22:20:22 UTC) #24
xhwang
lgtm
3 years, 7 months ago (2017-05-19 22:21:07 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893853003/40001
3 years, 7 months ago (2017-05-20 01:12:48 UTC) #27
commit-bot: I haz the power
3 years, 7 months ago (2017-05-20 04:25:06 UTC) #30
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d07d1d29fc7cda26a10b4d1283d1...

Powered by Google App Engine
This is Rietveld 408576698