|
|
Created:
3 years, 7 months ago by Haoming Chen Modified:
3 years, 7 months ago CC:
chromium-reviews, eme-reviews_chromium.org, tinskip1, krasin1, Rintaro Kuroiwa, jrummell Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Use Stub CDM for building libwidevinecdmadapter.so (patchset #4 id:100001 of https://codereview.chromium.org/2792743002/ )
Reason for revert:
Using stub cdm is a workaround and it breaks the load_library_perf_test.
This change reverts the stub cdm because the unaligned ELF header issue
has been fixed for libwidevinecdm.so, so that we can re-enable the
load_library_perf_test.
Original issue's description:
> Use Stub CDM for building libwidevinecdmadapter.so
>
> - This is a temporary fix for unblocking LLD.
> - We use the stub CDM to build the CDM adapter.
> - We ship the copied (real) CDM and the CDM adapter.
> - Even though the CDM adapter is built against the stub cdm at
> "stub_cdm/libwidevinecdm.so", only the filename is baked
> into the adapter because of the gn dependency,
> e.g., readelf -d libwidevinecdmadapter.so :
> 0x0000000000000001 (NEEDED) Shared library: [libwidevinecdm.so]
> - At run time, when loading the CDM adapter, the system will search
> for the CDM in the same dir where the adapter is located. Hence
> the real CDM will be loaded.
>
> BUG=707488
>
> Review-Url: https://codereview.chromium.org/2792743002
> Cr-Commit-Position: refs/heads/master@{#462104}
> Committed: https://chromium.googlesource.com/chromium/src/+/4bd7678fefa459f3f29a4ea511ff26971cfb5648
TBR=xhwang@chromium.org,hmchen@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=707488
Review-Url: https://codereview.chromium.org/2893853003
Cr-Commit-Position: refs/heads/master@{#473408}
Committed: https://chromium.googlesource.com/chromium/src/+/d07d1d29fc7cda26a10b4d1283d1af86aae9a755
Patch Set 1 #Patch Set 2 : Rebase and resolve conflicts. #Messages
Total messages: 30 (13 generated)
The CQ bit was checked by hmchen@chromium.org
Created Revert of Use Stub CDM for building libwidevinecdmadapter.so
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by hmchen@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by hmchen@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by hmchen@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by hmchen@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2017/05/19 17:10:59, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) It seems you need to rebase this CL now (see the patch failure).
On 2017/05/19 21:12:15, xhwang wrote: > On 2017/05/19 17:10:59, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) > > It seems you need to rebase this CL now (see the patch failure). Thanks. I did a rebase and resolved a conflict. PTAL.
lgtm
The CQ bit was checked by hmchen@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495242727768850, "parent_rev": "27d1ff58a6ae0788d6f9d776d3c593d853e919aa", "commit_rev": "d07d1d29fc7cda26a10b4d1283d1af86aae9a755"}
Message was sent while issue was closed.
Description was changed from ========== Revert of Use Stub CDM for building libwidevinecdmadapter.so (patchset #4 id:100001 of https://codereview.chromium.org/2792743002/ ) Reason for revert: Using stub cdm is a workaround and it breaks the load_library_perf_test. This change reverts the stub cdm because the unaligned ELF header issue has been fixed for libwidevinecdm.so, so that we can re-enable the load_library_perf_test. Original issue's description: > Use Stub CDM for building libwidevinecdmadapter.so > > - This is a temporary fix for unblocking LLD. > - We use the stub CDM to build the CDM adapter. > - We ship the copied (real) CDM and the CDM adapter. > - Even though the CDM adapter is built against the stub cdm at > "stub_cdm/libwidevinecdm.so", only the filename is baked > into the adapter because of the gn dependency, > e.g., readelf -d libwidevinecdmadapter.so : > 0x0000000000000001 (NEEDED) Shared library: [libwidevinecdm.so] > - At run time, when loading the CDM adapter, the system will search > for the CDM in the same dir where the adapter is located. Hence > the real CDM will be loaded. > > BUG=707488 > > Review-Url: https://codereview.chromium.org/2792743002 > Cr-Commit-Position: refs/heads/master@{#462104} > Committed: https://chromium.googlesource.com/chromium/src/+/4bd7678fefa459f3f29a4ea511ff... TBR=xhwang@chromium.org,hmchen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=707488 ========== to ========== Revert of Use Stub CDM for building libwidevinecdmadapter.so (patchset #4 id:100001 of https://codereview.chromium.org/2792743002/ ) Reason for revert: Using stub cdm is a workaround and it breaks the load_library_perf_test. This change reverts the stub cdm because the unaligned ELF header issue has been fixed for libwidevinecdm.so, so that we can re-enable the load_library_perf_test. Original issue's description: > Use Stub CDM for building libwidevinecdmadapter.so > > - This is a temporary fix for unblocking LLD. > - We use the stub CDM to build the CDM adapter. > - We ship the copied (real) CDM and the CDM adapter. > - Even though the CDM adapter is built against the stub cdm at > "stub_cdm/libwidevinecdm.so", only the filename is baked > into the adapter because of the gn dependency, > e.g., readelf -d libwidevinecdmadapter.so : > 0x0000000000000001 (NEEDED) Shared library: [libwidevinecdm.so] > - At run time, when loading the CDM adapter, the system will search > for the CDM in the same dir where the adapter is located. Hence > the real CDM will be loaded. > > BUG=707488 > > Review-Url: https://codereview.chromium.org/2792743002 > Cr-Commit-Position: refs/heads/master@{#462104} > Committed: https://chromium.googlesource.com/chromium/src/+/4bd7678fefa459f3f29a4ea511ff... TBR=xhwang@chromium.org,hmchen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=707488 Review-Url: https://codereview.chromium.org/2893853003 Cr-Commit-Position: refs/heads/master@{#473408} Committed: https://chromium.googlesource.com/chromium/src/+/d07d1d29fc7cda26a10b4d1283d1... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/d07d1d29fc7cda26a10b4d1283d1... |