Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Issue 2893833003: [Android] Give public versions of notifications a channel (Closed)

Created:
3 years, 7 months ago by awdf
Modified:
3 years, 7 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Give public versions of notifications a channel - In practice they seem to get assigned to the non-public version's channel, but this isn't guaranteed by the API. - This change also means we won't have to put this file on a whitelist for an upcoming presubmit check. BUG=678670, 702628 Review-Url: https://codereview.chromium.org/2893833003 Cr-Commit-Position: refs/heads/master@{#473159} Committed: https://chromium.googlesource.com/chromium/src/+/c3a8b7831c0598f303b34495a7396f06d4760d8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java View 2 chunks +6 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (6 generated)
Peter Beverloo
lgtm
3 years, 7 months ago (2017-05-18 20:43:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893833003/1
3 years, 7 months ago (2017-05-19 10:37:01 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 11:25:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c3a8b7831c0598f303b34495a739...

Powered by Google App Engine
This is Rietveld 408576698