third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp - Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler (Closed)

Patch Set: use popup window for payment handler Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/service_worker/service_worker_messages.h ('K') | « third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

index ee7a500cb2535666ff10a57600bc71332f9a3560..8d205c4963c78af7a52a2bcaa23023103e5e3e6b 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

@@ -185,7 +185,7 @@ ScriptPromise ServiceWorkerClients::openWindow(ScriptState* script_state,

}

context->ConsumeWindowInteraction();

- ServiceWorkerGlobalScopeClient::From(context)->OpenWindow(

+ ServiceWorkerGlobalScopeClient::From(context)->OpenWindowForClients(

parsed_url, WTF::MakeUnique<NavigateClientCallback>(resolver));

return promise;

}