Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: content/common/service_worker/service_worker_messages.h

Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler (Closed)
Patch Set: use popup window for payment handler Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/service_worker/service_worker_messages.h
diff --git a/content/common/service_worker/service_worker_messages.h b/content/common/service_worker/service_worker_messages.h
index ef5a82603f3ad008980345e9460d5ba090865388..9aedc0ae5d0e38680916e01e8aa695aadd3785f9 100644
--- a/content/common/service_worker/service_worker_messages.h
+++ b/content/common/service_worker/service_worker_messages.h
@@ -271,8 +271,13 @@ IPC_MESSAGE_ROUTED2(ServiceWorkerHostMsg_SetCachedMetadata,
// clear the cache associated with |url|.
IPC_MESSAGE_ROUTED1(ServiceWorkerHostMsg_ClearCachedMetadata, GURL /* url */)
-// Ask the browser to open a tab/window (renderer->browser).
-IPC_MESSAGE_ROUTED2(ServiceWorkerHostMsg_OpenWindow,
+// Ask the browser to open a tab/window (renderer->browser) for clients.
please use gerrit instead 2017/06/02 03:43:17 ... for clients.openWindow().
gogerald1 2017/06/02 13:21:40 Done.
+IPC_MESSAGE_ROUTED2(ServiceWorkerHostMsg_OpenWindowForClients,
+ int /* request_id */,
+ GURL /* url */)
+
+// Ask the browser to open a tab/window (renderer->browser) for payment handler.
please use gerrit instead 2017/06/02 03:43:17 ... for payment handler, i.e., PaymentRequestEvent
gogerald1 2017/06/02 13:21:40 Done.
+IPC_MESSAGE_ROUTED2(ServiceWorkerHostMsg_OpenWindowForPaymentHandler,
int /* request_id */,
GURL /* url */)

Powered by Google App Engine
This is Rietveld 408576698