Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2893823003: Flush all TaskScheduler<->MainLoop tasks in ~TestBrowserThreadBundle() (Closed)

Created:
3 years, 7 months ago by gab
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jam, danakj+watch_chromium.org, darin-cc_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Flush all TaskScheduler<->MainLoop tasks in ~TestBrowserThreadBundle() And update a bit of documentation on why some things are done a certain way. BUG=724086 Review-Url: https://codereview.chromium.org/2893823003 Cr-Commit-Position: refs/heads/master@{#472864} Committed: https://chromium.googlesource.com/chromium/src/+/13c37ee0b4babbdec65c0ea3c68c9d771999689c

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M base/test/scoped_task_environment.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/public/test/test_browser_thread_bundle.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M content/public/test/test_utils.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
gab
Francois PTaL, thanks
3 years, 7 months ago (2017-05-18 14:58:59 UTC) #6
fdoray
lgtm
3 years, 7 months ago (2017-05-18 15:27:47 UTC) #8
gab
@avi for content rubberstamp, please CQ if LGTY
3 years, 7 months ago (2017-05-18 16:15:18 UTC) #10
Avi (use Gerrit)
lgtm stamp
3 years, 7 months ago (2017-05-18 17:39:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893823003/20001
3 years, 7 months ago (2017-05-18 17:40:31 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 17:48:06 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/13c37ee0b4babbdec65c0ea3c68c...

Powered by Google App Engine
This is Rietveld 408576698