Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2893793004: Upstream service wrkr "respond with" tests to WPT (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream service wrkr "respond with" tests to WPT **(fetch-event-)respond-with-readable-stream** **(fetch-event-)respond-with-response-body-with-invalid-chunk** Re-locate test files to Web Platform Test directory for eventual automated upstreaming. Modify file names according to convention set by related tests in that project. Update resource URLs to suitable values for that project. Schedule frame removal to occur following test completion. Introduce a "use strict" directive. Simplify Promise creation. BUG=688116 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2893793004 Cr-Commit-Position: refs/heads/master@{#473232} Committed: https://chromium.googlesource.com/chromium/src/+/1ab24e6317f69a8fc15f1f12023a8c98fb065ce2

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove declaration of unused binding #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -109 lines) Patch
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-readable-stream.https.html View 1 2 chunks +10 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-response-body-with-invalid-chunk.https.html View 1 2 chunks +10 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-event-respond-with-readable-stream-iframe.html View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-event-respond-with-readable-stream-worker.js View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-event-respond-with-response-body-with-invalid-chunk-iframe.html View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-event-respond-with-response-body-with-invalid-chunk-worker.js View 1 chunk +2 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/respond-with-readable-stream-iframe.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/respond-with-readable-stream-worker.js View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/respond-with-response-body-with-invalid-chunk-iframe.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/respond-with-response-body-with-invalid-chunk-worker.js View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/respond-with-readable-stream.html View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/respond-with-response-body-with-invalid-chunk.html View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
falken
lgtm https://codereview.chromium.org/2893793004/diff/1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-readable-stream.https.html File third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-readable-stream.https.html (right): https://codereview.chromium.org/2893793004/diff/1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-readable-stream.https.html#newcode14 third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-readable-stream.https.html:14: var resolve_done; resolve_done can be removed https://codereview.chromium.org/2893793004/diff/1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-response-body-with-invalid-chunk.https.html File ...
3 years, 7 months ago (2017-05-19 04:00:45 UTC) #1
mike3
Thanks for the review! https://codereview.chromium.org/2893793004/diff/1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-readable-stream.https.html File third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-readable-stream.https.html (right): https://codereview.chromium.org/2893793004/diff/1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-readable-stream.https.html#newcode14 third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-readable-stream.https.html:14: var resolve_done; On 2017/05/19 04:00:45, ...
3 years, 7 months ago (2017-05-19 16:19:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893793004/20001
3 years, 7 months ago (2017-05-19 16:20:20 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 17:34:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1ab24e6317f69a8fc15f1f12023a...

Powered by Google App Engine
This is Rietveld 408576698