Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2893793002: Remove mutable reference argument for //device/generic_sensor/platform_sensor_reader_win.* (Closed)

Created:
3 years, 7 months ago by juncai
Modified:
3 years, 7 months ago
CC:
chromium-reviews, wanming.lin, shalamov, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove mutable reference argument for //device/generic_sensor/platform_sensor_reader_win.* Google C++ coding style does not permit mutable reference arguments. This CL fixes it for //device/generic_sensor/platform_sensor_reader_win.* BUG=718457 Review-Url: https://codereview.chromium.org/2893793002 Cr-Commit-Position: refs/heads/master@{#472926} Committed: https://chromium.googlesource.com/chromium/src/+/28a065e82bfd0d01fb5d7096ce2311ee6aeb92a7

Patch Set 1 : remove mutable reference argument for //device/generic_sensor/platform_sensor_reader_win.* #

Patch Set 2 : fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M device/generic_sensor/platform_sensor_reader_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M device/generic_sensor/platform_sensor_reader_win.cc View 1 13 chunks +32 lines, -32 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
juncai
Please take a look.
3 years, 7 months ago (2017-05-18 19:08:19 UTC) #11
Reilly Grant (use Gerrit)
lgtm
3 years, 7 months ago (2017-05-18 20:38:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893793002/20001
3 years, 7 months ago (2017-05-18 20:46:40 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 20:55:58 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/28a065e82bfd0d01fb5d7096ce23...

Powered by Google App Engine
This is Rietveld 408576698