Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2893773003: Use wakelock mojo interface instead of PowerSaveBlocker in renderer_host. (Closed)

Created:
3 years, 7 months ago by ke.he
Modified:
3 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use wakelock mojo interface instead of PowerSaveBlocker in renderer_host. Wake Lock is a Mojo interface that wraps PowerSaveBlocker, As part of the creation of standalone Device Service, all browser-side clients of PowerSaveBlocker should be converted to be clients of WakeLock mojo interface instead. This CL converts clients of PowerSaveBlocker in //content/browser/renderer_host/ BUG=689410 Review-Url: https://codereview.chromium.org/2893773003 Cr-Commit-Position: refs/heads/master@{#473034} Committed: https://chromium.googlesource.com/chromium/src/+/2334c53d452d01b8ce2f5b40b94eca119c424234

Patch Set 1 #

Patch Set 2 : Use wakelock mojo interface instead of PowerSaveBlocker in renderer_host. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -17 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.h View 4 chunks +9 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 4 chunks +32 lines, -10 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
ke.he
Hi, Jam@, Could you PTAL on this, Thanks!
3 years, 7 months ago (2017-05-18 09:53:39 UTC) #8
jam
lgtm
3 years, 7 months ago (2017-05-18 14:26:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893773003/20001
3 years, 7 months ago (2017-05-18 16:37:15 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/448745)
3 years, 7 months ago (2017-05-18 22:45:42 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893773003/20001
3 years, 7 months ago (2017-05-19 02:11:21 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 02:17:35 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2334c53d452d01b8ce2f5b40b94e...

Powered by Google App Engine
This is Rietveld 408576698