Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 2893763002: [ObjC ARC] Converts ios/chrome/test/earl_grey:ios_chrome_smoke_egtests to ARC. (Closed)

Created:
3 years, 7 months ago by liaoyuke
Modified:
3 years, 7 months ago
Reviewers:
baxley
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/test/earl_grey:ios_chrome_smoke_egtests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2893763002 Cr-Commit-Position: refs/heads/master@{#473597} Committed: https://chromium.googlesource.com/chromium/src/+/09f302179d78baa49db21cb906684c26467219c6

Patch Set 1 #

Patch Set 2 : Fix auto arc script errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/test/earl_grey/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/test/earl_grey/smoke_egtest.mm View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
liaoyuke
Hey Mike, PTAL. Thank you very much!
3 years, 7 months ago (2017-05-18 18:08:08 UTC) #6
baxley
lgtm
3 years, 7 months ago (2017-05-18 22:23:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893763002/20001
3 years, 7 months ago (2017-05-18 22:29:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/388192)
3 years, 7 months ago (2017-05-18 23:07:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893763002/20001
3 years, 7 months ago (2017-05-19 05:05:01 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/449531)
3 years, 7 months ago (2017-05-19 07:26:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893763002/20001
3 years, 7 months ago (2017-05-22 15:39:30 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 16:38:47 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/09f302179d78baa49db21cb90668...

Powered by Google App Engine
This is Rietveld 408576698