Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2893743003: Upstream service wrkr "registration" tests to WPT (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream service wrkr "registration" tests to WPT **registration** This test file was upstreamed to the Web Platform Tests project in Chromium commit e46007715a723c2219f49db6199f1af09cbbc7db, but the associated "expectations" file was mistakenly persisted. Remove the expectations file. **registration-end-to-end** The version of this test in the Chromium source tree is equivalent to the version available in the Web Platform Tests project. Remove the Chromium version. **registration-events** The version of this test in the Chromium source tree is equivalent to the version available in the Web Platform Tests project. Remove the Chromium version. **registration-service-worker-attributes** The version defined by the Chromium project is more strict in that it does not allow workers to transition between states before Promise resolution microtasks have been executed. Because any such transition would be in violation of the service workers specification, the additional strictness is preferable. Remove the logic that relaxes the WPT version of this test, and remove the Chromium test file entirely. BUG=688116 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2893743003 Cr-Commit-Position: refs/heads/master@{#472821} Committed: https://chromium.googlesource.com/chromium/src/+/f5a2de23dd577e4235b22719e127831dcb5f37b3

Patch Set 1 #

Total comments: 1

Messages

Total messages: 7 (3 generated)
falken
lgtm https://codereview.chromium.org/2893743003/diff/1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/registration-service-worker-attributes.https.html File third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/registration-service-worker-attributes.https.html (right): https://codereview.chromium.org/2893743003/diff/1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/registration-service-worker-attributes.https.html#newcode6 third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/registration-service-worker-attributes.https.html:6: 'use strict'; Are we going to add this ...
3 years, 7 months ago (2017-05-18 02:26:13 UTC) #1
mike3
On 2017/05/18 02:26:13, falken wrote: > lgtm > > https://codereview.chromium.org/2893743003/diff/1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/registration-service-worker-attributes.https.html > File > third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/registration-service-worker-attributes.https.html > ...
3 years, 7 months ago (2017-05-18 14:24:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893743003/1
3 years, 7 months ago (2017-05-18 14:24:47 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 15:29:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f5a2de23dd577e4235b22719e127...

Powered by Google App Engine
This is Rietveld 408576698