Removed a delay that is no longer necessary.

Removed a delay that is no longer necessary.

Earlier versions of Chrome using UIWebView requires a delay when
launching external apps that is no longer necessary. Removed some
unnecessary intermediate methods.

Review-Url: https://codereview.chromium.org/2893743002
Cr-Commit-Position: refs/heads/master@{#473036}
Committed: https://chromium.googlesource.com/chromium/src/+/810aea92c8ee9d753927571175ba978cf613d345

[pkl (ping after 24h if needed), 2017-05-18 22:23:35]

pkl@chromium.org changed reviewers:
+ eugenebut@chromium.org

[pkl (ping after 24h if needed), 2017-05-18 22:23:35]

Sorry, there still isn't any unit tests. I looked at adding some but it is not
easy in the current state.

My next step is to remove use of deprecated -openURL: (which requires turning
the API into an async API) and refactor the interface so adding unit tests will
be possible.

[Eugene But (OOO till 7-30), 2017-05-18 23:40:15]

lgtm

https://codereview.chromium.org/2893743002/diff/60001/ios/chrome/browser/web/...
File ios/chrome/browser/web/external_app_launcher.mm (right):

https://codereview.chromium.org/2893743002/diff/60001/ios/chrome/browser/web/...
ios/chrome/browser/web/external_app_launcher.mm:82: action:(NSString*)openLabel;
s/action/openLabel ?

https://codereview.chromium.org/2893743002/diff/60001/ios/chrome/browser/web/...
ios/chrome/browser/web/external_app_launcher.mm:155: [self
openExternalAppWithURL:URL
Optional nit: Maybe pass GURL to openExternalAppWithURL and convert it there?

[pkl (ping after 24h if needed), 2017-05-19 00:59:34]

https://codereview.chromium.org/2893743002/diff/60001/ios/chrome/browser/web/...
File ios/chrome/browser/web/external_app_launcher.mm (right):

https://codereview.chromium.org/2893743002/diff/60001/ios/chrome/browser/web/...
ios/chrome/browser/web/external_app_launcher.mm:82: action:(NSString*)openLabel;
On 2017/05/18 23:40:14, Eugene But wrote:
> s/action/openLabel ?

Done.

https://codereview.chromium.org/2893743002/diff/60001/ios/chrome/browser/web/...
ios/chrome/browser/web/external_app_launcher.mm:155: [self
openExternalAppWithURL:URL
On 2017/05/18 23:40:15, Eugene But wrote:
> Optional nit: Maybe pass GURL to openExternalAppWithURL and convert it there?

I'll save this for the next iteration of refactoring.

[pkl (ping after 24h if needed), 2017-05-19 00:59:44]

The CQ bit was checked by pkl@chromium.org

[pkl (ping after 24h if needed), 2017-05-19 00:59:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2893743002/#ps80001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-05-19 01:01:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 02:19:52]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495155584565990,
"parent_rev": "e111db0385aeceaf3e0c03f3f57568f908be46b5", "commit_rev":
"810aea92c8ee9d753927571175ba978cf613d345"}

[commit-bot: I haz the power, 2017-05-19 02:20:08]

Description was changed from

==========
Removed a delay that is no longer necessary.

Earlier versions of Chrome using UIWebView requires a delay when
launching external apps that is no longer necessary. Removed some
unnecessary intermediate methods.
==========

to

==========
Removed a delay that is no longer necessary.

Earlier versions of Chrome using UIWebView requires a delay when
launching external apps that is no longer necessary. Removed some
unnecessary intermediate methods.

Review-Url: https://codereview.chromium.org/2893743002
Cr-Commit-Position: refs/heads/master@{#473036}
Committed:
https://chromium.googlesource.com/chromium/src/+/810aea92c8ee9d753927571175ba...
==========

[commit-bot: I haz the power, 2017-05-19 02:20:10]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/810aea92c8ee9d753927571175ba...