Make EnabledRangeInEditableText return false for user-triggered command and unfocused selection

Make EnabledRangeInEditableText return false for user-triggered command and unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledRangeInEditableText() to fix
the behavior of the RemoveFormat command.

BUG=722925
TEST=editing/execCommand/remove_format_with_unfocused_selection.html

Review-Url: https://codereview.chromium.org/2893713003
Cr-Commit-Position: refs/heads/master@{#472635}
Committed: https://chromium.googlesource.com/chromium/src/+/8aaa656f06ce8379a55bf81fa4cdca123ff43485

[Xiaocheng, 2017-05-17 20:29:04]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 20:30:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 22:55:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 22:55:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2017-05-17 23:01:15]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 23:03:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-18 00:06:31]

Description was changed from

==========
Make EnableRangeInEditableText return false for user-triggered command and
unfocused selection

BUG=
==========

to

==========
Make EnableRangeInEditableText return false for user-triggered command and
unfocused selection



BUG=722925
==========

[Xiaocheng, 2017-05-18 00:07:36]

Description was changed from

==========
Make EnableRangeInEditableText return false for user-triggered command and
unfocused selection



BUG=722925
==========

to

==========
Make EnabledRangeInEditableText return false for user-triggered command and
unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledRangeInEditableText() to fix
the behavior of the RemoveFormat command.

BUG=722925
TEST=editing/execCommand/remove_format_with_unfocused_selection.html
==========

[Xiaocheng, 2017-05-18 00:07:47]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-18 00:07:48]

PTAL.

[yosin_UTC9, 2017-05-18 01:01:07]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-05-18 01:01:12]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-05-18 01:01:12]

lgtm

[commit-bot: I haz the power, 2017-05-18 01:01:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 03:29:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495069272105510, "parent_rev":
"596baeaaa2a5632f606a226ebdf898272cd4284d", "commit_rev":
"8aaa656f06ce8379a55bf81fa4cdca123ff43485"}

[commit-bot: I haz the power, 2017-05-18 03:29:19]

Description was changed from

==========
Make EnabledRangeInEditableText return false for user-triggered command and
unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledRangeInEditableText() to fix
the behavior of the RemoveFormat command.

BUG=722925
TEST=editing/execCommand/remove_format_with_unfocused_selection.html
==========

to

==========
Make EnabledRangeInEditableText return false for user-triggered command and
unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledRangeInEditableText() to fix
the behavior of the RemoveFormat command.

BUG=722925
TEST=editing/execCommand/remove_format_with_unfocused_selection.html

Review-Url: https://codereview.chromium.org/2893713003
Cr-Commit-Position: refs/heads/master@{#472635}
Committed:
https://chromium.googlesource.com/chromium/src/+/8aaa656f06ce8379a55bf81fa4cd...
==========

[commit-bot: I haz the power, 2017-05-18 03:29:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8aaa656f06ce8379a55bf81fa4cd...