Selection follows focus/activedescendant in single selection containers

Selection follows focus/activedescendant in single selection containers

BUG=722503
Review-Url: https://codereview.chromium.org/2893683002
Cr-Commit-Position: refs/heads/master@{#474303}
Committed: https://chromium.googlesource.com/chromium/src/+/5730ebb5038385964944377c1256244068b134d1

[aleventhal, 2017-05-17 17:36:57]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 17:38:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 18:58:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 18:58:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aleventhal, 2017-05-19 17:38:32]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 17:39:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-05-19 17:39:19]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 17:39:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-05-19 18:03:17]

Description was changed from

==========
Selection follows focus/activedescendant in single selection containers

BUG=722504
==========

to

==========
Selection follows focus/activedescendant in single selection containers

BUG=722504
==========

[aleventhal, 2017-05-19 18:03:18]

aleventhal@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[aleventhal, 2017-05-19 18:05:40]

Ready for review

[commit-bot: I haz the power, 2017-05-19 19:00:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 19:00:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2017-05-19 19:54:05]

Change looks good, wondering if we can or should
tighten it up a bit more

https://codereview.chromium.org/2893683002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/2893683002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:1301:
IsEnabled()) {
Do we need to check if the container is enabled or does
IsEnabled do that?

https://codereview.chromium.org/2893683002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp (right):

https://codereview.chromium.org/2893683002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp:1279:
AXObjectImpl* AXObjectImpl::ContainerWidget() const {
Should this check for the right type of container?

I.e. if you're on an option it should only walk
up to a container listbox, not a grid or toolbar.

Also, even though the spec seems to imply that
containers can have descendants anywhere, in many
cases the descendants have to be immediate children
for it to work on most platforms.

So the listitem has to be an immediate child of the
list, for example, or a group in some cases. You
can't have another non-presentational object in-between.

[dmazzoni, 2017-05-19 19:54:05]

Change looks good, wondering if we can or should
tighten it up a bit more

[aleventhal, 2017-05-19 20:14:38]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 20:15:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-05-19 20:16:55]

On 2017/05/19 19:54:05, dmazzoni wrote:
> Change looks good, wondering if we can or should
> tighten it up a bit more
> 
>
https://codereview.chromium.org/2893683002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right):
> 
>
https://codereview.chromium.org/2893683002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:1301:
> IsEnabled()) {
> Do we need to check if the container is enabled or does
> IsEnabled do that?
> 
>
https://codereview.chromium.org/2893683002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp (right):
> 
>
https://codereview.chromium.org/2893683002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp:1279:
> AXObjectImpl* AXObjectImpl::ContainerWidget() const {
> Should this check for the right type of container?
> 
> I.e. if you're on an option it should only walk
> up to a container listbox, not a grid or toolbar.
> 
> Also, even though the spec seems to imply that
> containers can have descendants anywhere, in many
> cases the descendants have to be immediate children
> for it to work on most platforms.
> 
> So the listitem has to be an immediate child of the
> list, for example, or a group in some cases. You
> can't have another non-presentational object in-between.

I was just going for bang-for-the-buck on logical complexity. If the author
writes crazy stuff there's probably a lot of cases where the various browsers
will act weird, in different ways from each other.

IMO it's better to keep it simple here unless we have a good reason.

[commit-bot: I haz the power, 2017-05-19 21:41:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 21:41:30]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[aleventhal, 2017-05-20 23:12:02]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-20 23:12:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-21 00:20:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-21 00:21:00]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aleventhal, 2017-05-21 01:12:59]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-21 01:13:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-21 01:22:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-21 01:22:14]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[aleventhal, 2017-05-21 01:32:41]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-21 01:32:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-21 03:17:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-21 03:17:55]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[aleventhal, 2017-05-21 05:18:17]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-21 05:18:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-21 06:24:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-21 06:24:36]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aleventhal, 2017-05-21 14:13:31]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-21 14:13:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-21 15:24:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-21 15:24:51]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aleventhal, 2017-05-21 22:11:44]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-21 22:11:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-21 23:48:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-21 23:48:52]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[aleventhal, 2017-05-22 18:34:02]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 18:35:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-05-22 18:35:55]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 18:36:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-05-22 18:47:38]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 18:47:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 20:11:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 20:11:08]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dmazzoni, 2017-05-22 20:59:31]

lgtm

[aleventhal, 2017-05-22 23:33:41]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 23:34:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-05-22 23:38:27]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 23:39:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 00:56:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 00:56:46]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[aleventhal, 2017-05-23 02:13:21]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 02:13:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 04:09:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 04:09:32]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[aleventhal, 2017-05-23 12:28:35]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 12:28:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 14:14:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 14:14:04]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[aleventhal, 2017-05-23 15:52:31]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 15:53:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 16:20:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 16:20:31]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[aleventhal, 2017-05-23 19:27:40]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 19:28:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 19:37:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 19:37:19]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aleventhal, 2017-05-23 20:05:40]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 20:06:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 23:46:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 23:46:15]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[aleventhal, 2017-05-23 23:54:55]

The CQ bit was checked by aleventhal@chromium.org

[aleventhal, 2017-05-23 23:54:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2893683002/#ps340001
(title: "Fix tests")

[commit-bot: I haz the power, 2017-05-23 23:55:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 03:04:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 03:04:53]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[aleventhal, 2017-05-24 03:43:27]

The CQ bit was checked by aleventhal@chromium.org

[commit-bot: I haz the power, 2017-05-24 03:44:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-05-24 04:19:42]

The CQ bit was checked by aleventhal@chromium.org

[aleventhal, 2017-05-24 04:19:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2893683002/#ps360001
(title: "Fix test syntax")

[commit-bot: I haz the power, 2017-05-24 04:20:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 08:01:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 08:01:03]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[aleventhal, 2017-05-24 12:14:00]

The CQ bit was checked by aleventhal@chromium.org

[aleventhal, 2017-05-24 12:14:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2893683002/#ps380001
(title: "Fix Android tests")

[commit-bot: I haz the power, 2017-05-24 12:14:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-05-24 13:44:50]

The CQ bit was checked by aleventhal@chromium.org

[aleventhal, 2017-05-24 13:44:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2893683002/#ps400001
(title: "Last test to fix we hope")

[commit-bot: I haz the power, 2017-05-24 13:45:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 15:51:26]

CQ is committing da patch.

Bot data: {"patchset_id": 400001, "attempt_start_ts": 1495633490380700,
"parent_rev": "6cd897e3feb8c33e7cfd003691eef6edf8265443", "commit_rev":
"5730ebb5038385964944377c1256244068b134d1"}

[commit-bot: I haz the power, 2017-05-24 15:51:51]

CQ is committing da patch.

Bot data: {"patchset_id": 400001, "attempt_start_ts": 1495633490380700,
"parent_rev": "6cd897e3feb8c33e7cfd003691eef6edf8265443", "commit_rev":
"5730ebb5038385964944377c1256244068b134d1"}

[commit-bot: I haz the power, 2017-05-24 15:51:57]

Description was changed from

==========
Selection follows focus/activedescendant in single selection containers

BUG=722504
==========

to

==========
Selection follows focus/activedescendant in single selection containers

BUG=722504

Review-Url: https://codereview.chromium.org/2893683002
Cr-Commit-Position: refs/heads/master@{#474303}
Committed:
https://chromium.googlesource.com/chromium/src/+/5730ebb5038385964944377c1256...
==========

[commit-bot: I haz the power, 2017-05-24 15:51:59]

Committed patchset #21 (id:400001) as
https://chromium.googlesource.com/chromium/src/+/5730ebb5038385964944377c1256...

[aleventhal, 2017-05-24 16:07:44]

Description was changed from

==========
Selection follows focus/activedescendant in single selection containers

BUG=722504

Review-Url: https://codereview.chromium.org/2893683002
Cr-Commit-Position: refs/heads/master@{#474303}
Committed:
https://chromium.googlesource.com/chromium/src/+/5730ebb5038385964944377c1256...
==========

to

==========
Selection follows focus/activedescendant in single selection containers

BUG=722503

Review-Url: https://codereview.chromium.org/2893683002
Cr-Commit-Position: refs/heads/master@{#474303}
Committed:
https://chromium.googlesource.com/chromium/src/+/5730ebb5038385964944377c1256...
==========

[David Tseng, 2017-06-06 20:58:29]

dtseng@chromium.org changed reviewers:
+ dtseng@chromium.org

[David Tseng, 2017-06-06 20:58:30]

As FYI. This cl regresses previous aria-selected behavior on a grid with an
active descendant. With this patch reverted, my example works. On trunk, it
fails.

https://codereview.chromium.org/2893683002/diff/400001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp (right):

https://codereview.chromium.org/2893683002/diff/400001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp:463: //
aria-selected overrides automatic behaviors
Note that this doesn't actually happen because the !CanSetSelectedAttribute()
returns early and CanSetSelectedAttribute() function never actually checks
aria-selected...

[David Tseng, 2017-06-06 21:28:47]

https://codereview.chromium.org/2893683002/diff/400001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/2893683002/diff/400001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:1330: role ==
kTreeItemRole || role == kCellRole || role == kTabRole) &&
The spec includes the roles:

gridcell
option
row
tab
Inherits into Roles:	
columnheader
rowheader
treeitem

[aleventhal, 2017-06-08 17:24:46]

On 2017/06/06 21:28:47, David Tseng wrote:
>
https://codereview.chromium.org/2893683002/diff/400001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right):
> 
>
https://codereview.chromium.org/2893683002/diff/400001/third_party/WebKit/Sou...
> third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:1330: role ==
> kTreeItemRole || role == kCellRole || role == kTabRole) &&
> The spec includes the roles:
> 
> gridcell
> option
> row
> tab
> Inherits into Roles:	
> columnheader
> rowheader
> treeitem

Hi David, what example regresses? Is it a grid with aria-multiselectable="true"
?