Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(19)

Issue 2893653002: Rename Ownership Transferring Methods for Prerenderer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week ago by jdoerrie - OOO til May 29th
Modified:
6 days, 2 hours ago
Reviewers:
Nico
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Ownership Transferring Methods for Prerenderer This change renames PrerenderManager::GetAsValue and PrerenderHistory::GetEntriesAsValue to a more fitting PrerenderManager::CopyAsValue and PrerenderHistory::CopyEntriesAsValue R=thakis@chromium.org BUG=NONE Review-Url: https://codereview.chromium.org/2893653002 Cr-Commit-Position: refs/heads/master@{#472814} Committed: https://chromium.googlesource.com/chromium/src/+/bdc3d1e6586e88b8b04ea17e5e454d57299c1545

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M chrome/browser/net/net_export_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_history.h View 2 chunks +2 lines, -2 lines 1 comment Download
M chrome/browser/prerender/prerender_history.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_history_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
Commit queue not available (can’t edit this change).

Depends on Patchset:

Messages

Total messages: 19 (11 generated)
jdoerrie - OOO til May 29th
https://codereview.chromium.org/2893653002/diff/1/chrome/browser/prerender/prerender_history.h File chrome/browser/prerender/prerender_history.h (right): https://codereview.chromium.org/2893653002/diff/1/chrome/browser/prerender/prerender_history.h#newcode80 chrome/browser/prerender/prerender_history.h:80: } // namespace prerender cpplint complained about this, that's ...
1 week ago (2017-05-17 16:29:04 UTC) #3
Nico
Lgtm, thanks!
1 week ago (2017-05-17 16:36:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893653002/1
6 days, 11 hours ago (2017-05-18 06:12:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/448309)
6 days, 9 hours ago (2017-05-18 08:10:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893653002/1
6 days, 5 hours ago (2017-05-18 12:22:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/448460)
6 days, 3 hours ago (2017-05-18 14:16:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893653002/1
6 days, 3 hours ago (2017-05-18 14:33:46 UTC) #16
commit-bot: I haz the power
6 days, 2 hours ago (2017-05-18 15:09:24 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bdc3d1e6586e88b8b04ea17e5e45...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06