[mus+ash] Removes WmWindow from ash/wm/window_cycle_*

[mus+ash] Removes WmWindow from ash/wm/window_cycle_*

Refactors Alt+Tab and starts refactoring Overview mode to use
aura::Window directly.

BUG=722553
TEST=None

Review-Url: https://codereview.chromium.org/2893643003
Cr-Commit-Position: refs/heads/master@{#472638}
Committed: https://chromium.googlesource.com/chromium/src/+/4b094092929ca499b94465bfefe68ebac5195947

[varkha, 2017-05-17 21:31:23]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 21:32:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2017-05-17 21:42:31]

Patchset #1 (id:1) has been deleted

[varkha, 2017-05-17 21:42:36]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 21:44:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2017-05-17 21:56:31]

varkha@chromium.org changed reviewers:
+ jamescook@chromium.org

[varkha, 2017-05-17 21:56:32]

jamescook@, can you please take a look? I am trying to keep those bite-sized.
Let me know if you have established some patterns of this work (e.g. if you want
to have it be larger / smaller in scope or touch specific areas or follow some
examples).
Thanks!

[commit-bot: I haz the power, 2017-05-17 22:58:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 22:58:28]

Dry run: This issue passed the CQ dry run.

[James Cook, 2017-05-17 23:18:26]

LGTM with nits. I like small chunks.

The only pattern we have so far is to prefer
ash::Shell::GetAllRootWindowControllers() to the other ways to get that data,
which is not relevant to this CL.

+sky just FYI, since I think he was going to work in //ash/wm too.

https://codereview.chromium.org/2893643003/diff/20001/ash/wm/window_cycle_con...
File ash/wm/window_cycle_controller.cc (right):

https://codereview.chromium.org/2893643003/diff/20001/ash/wm/window_cycle_con...
ash/wm/window_cycle_controller.cc:113: auto* active_window_after_window_cycle =
nit: I think aura::Window* would be a little clearer here

https://codereview.chromium.org/2893643003/diff/20001/ash/wm/window_cycle_con...
File ash/wm/window_cycle_controller_unittest.cc (right):

https://codereview.chromium.org/2893643003/diff/20001/ash/wm/window_cycle_con...
ash/wm/window_cycle_controller_unittest.cc:76: return
ash::wm::GetWindowState(window)->IsMinimized();
nit: Is ash:: needed here?

https://codereview.chromium.org/2893643003/diff/20001/ash/wm/window_cycle_lis...
File ash/wm/window_cycle_list.cc (right):

https://codereview.chromium.org/2893643003/diff/20001/ash/wm/window_cycle_lis...
ash/wm/window_cycle_list.cc:438:
ash::wm::GetWindowState(windows_[0])->Activate();
is ash:: needed here?

[varkha, 2017-05-18 00:18:30]

Thanks for a quick review!

https://codereview.chromium.org/2893643003/diff/20001/ash/wm/window_cycle_con...
File ash/wm/window_cycle_controller.cc (right):

https://codereview.chromium.org/2893643003/diff/20001/ash/wm/window_cycle_con...
ash/wm/window_cycle_controller.cc:113: auto* active_window_after_window_cycle =
On 2017/05/17 23:18:25, James Cook wrote:
> nit: I think aura::Window* would be a little clearer here

Done.

https://codereview.chromium.org/2893643003/diff/20001/ash/wm/window_cycle_con...
File ash/wm/window_cycle_controller_unittest.cc (right):

https://codereview.chromium.org/2893643003/diff/20001/ash/wm/window_cycle_con...
ash/wm/window_cycle_controller_unittest.cc:76: return
ash::wm::GetWindowState(window)->IsMinimized();
On 2017/05/17 23:18:26, James Cook wrote:
> nit: Is ash:: needed here?
> 

Done.

https://codereview.chromium.org/2893643003/diff/20001/ash/wm/window_cycle_lis...
File ash/wm/window_cycle_list.cc (right):

https://codereview.chromium.org/2893643003/diff/20001/ash/wm/window_cycle_lis...
ash/wm/window_cycle_list.cc:438:
ash::wm::GetWindowState(windows_[0])->Activate();
On 2017/05/17 23:18:26, James Cook wrote:
> is ash:: needed here?

Done.

[varkha, 2017-05-18 00:19:26]

The CQ bit was checked by varkha@chromium.org

[varkha, 2017-05-18 00:19:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2893643003/#ps40001
(title: "[mus+ash] Removes WmWindow from ash/wm/window_cycle_* (nits)")

[commit-bot: I haz the power, 2017-05-18 00:20:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 03:36:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495066766320470,
"parent_rev": "f4af9a035994eace456a72a30d90186479f15238", "commit_rev":
"4b094092929ca499b94465bfefe68ebac5195947"}

[commit-bot: I haz the power, 2017-05-18 03:36:50]

Description was changed from

==========
[mus+ash] Removes WmWindow from ash/wm/window_cycle_*

Refactors Alt+Tab and starts refactoring Overview mode to use
aura::Window directly.

BUG=722553
TEST=None
==========

to

==========
[mus+ash] Removes WmWindow from ash/wm/window_cycle_*

Refactors Alt+Tab and starts refactoring Overview mode to use
aura::Window directly.

BUG=722553
TEST=None

Review-Url: https://codereview.chromium.org/2893643003
Cr-Commit-Position: refs/heads/master@{#472638}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b094092929ca499b94465bfefe6...
==========

[commit-bot: I haz the power, 2017-05-18 03:36:51]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4b094092929ca499b94465bfefe6...