VR: Make sure GL thread is started before binding callbacks to it.

VR: Make sure GL thread is started before binding callbacks to it.

BUG=723262
Review-Url: https://codereview.chromium.org/2893623002
Cr-Commit-Position: refs/heads/master@{#472475}
Committed: https://chromium.googlesource.com/chromium/src/+/5f7ac3af3be63d35ecba7c6814c842f4d1c12da3

[mthiesse, 2017-05-17 15:23:39]

mthiesse@chromium.org changed reviewers:
+ cjgrant@chromium.org, ymalik@chromium.org

[mthiesse, 2017-05-17 15:23:39]

PTAL

[Ian Vollick, 2017-05-17 15:27:58]

vollick@chromium.org changed reviewers:
+ vollick@chromium.org

[Ian Vollick, 2017-05-17 15:27:58]

https://codereview.chromium.org/2893623002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2893623002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell.cc:258: PostToGlThread(
With this helper, won't the FROM_HERE in PostToGlThread give no useful info? Why
not name the helper something like "post when the thread's ready", move
WaitForGlThread into it, and pass it FROM_HERE?

[mthiesse, 2017-05-17 15:37:08]

https://codereview.chromium.org/2893623002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2893623002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell.cc:258: PostToGlThread(
On 2017/05/17 15:27:58, Ian Vollick wrote:
> With this helper, won't the FROM_HERE in PostToGlThread give no useful info?
Why
> not name the helper something like "post when the thread's ready", move
> WaitForGlThread into it, and pass it FROM_HERE?

Can't do as you ask, but as discussed offline, I've added the location to the
parameters.

[Ian Vollick, 2017-05-17 15:41:19]

On 2017/05/17 15:37:08, mthiesse wrote:
>
https://codereview.chromium.org/2893623002/diff/1/chrome/browser/android/vr_s...
> File chrome/browser/android/vr_shell/vr_shell.cc (right):
> 
>
https://codereview.chromium.org/2893623002/diff/1/chrome/browser/android/vr_s...
> chrome/browser/android/vr_shell/vr_shell.cc:258: PostToGlThread(
> On 2017/05/17 15:27:58, Ian Vollick wrote:
> > With this helper, won't the FROM_HERE in PostToGlThread give no useful info?
> Why
> > not name the helper something like "post when the thread's ready", move
> > WaitForGlThread into it, and pass it FROM_HERE?
> 
> Can't do as you ask, but as discussed offline, I've added the location to the
> parameters.

Thanks. lgtm.

[mthiesse, 2017-05-17 15:42:31]

The CQ bit was checked by mthiesse@chromium.org

[commit-bot: I haz the power, 2017-05-17 15:43:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 16:32:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495035751190160,
"parent_rev": "0feff5f517e63ec7ecf04192464c61c57f9e1686", "commit_rev":
"5f7ac3af3be63d35ecba7c6814c842f4d1c12da3"}

[commit-bot: I haz the power, 2017-05-17 16:32:46]

Description was changed from

==========
VR: Make sure GL thread is started before binding callbacks to it.

BUG=723262
==========

to

==========
VR: Make sure GL thread is started before binding callbacks to it.

BUG=723262

Review-Url: https://codereview.chromium.org/2893623002
Cr-Commit-Position: refs/heads/master@{#472475}
Committed:
https://chromium.googlesource.com/chromium/src/+/5f7ac3af3be63d35ecba7c6814c8...
==========

[commit-bot: I haz the power, 2017-05-17 16:32:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5f7ac3af3be63d35ecba7c6814c8...