Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2893573004: Simplify some code in c/b/u/views. (Closed)

Created:
3 years, 7 months ago by Evan Stade
Modified:
3 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify some code in c/b/u/views. This was a result of looking at GetPreferredSize overrides and asking whether they're really necessary. BUG=none Review-Url: https://codereview.chromium.org/2893573004 Cr-Commit-Position: refs/heads/master@{#472955} Committed: https://chromium.googlesource.com/chromium/src/+/2bb48c8a1af8c61799d7a1e3031d956deb61730b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -59 lines) Patch
M chrome/browser/ui/views/location_bar/keyword_hint_view.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/keyword_hint_view.cc View 6 chunks +27 lines, -46 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/validation_message_bubble_view.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/validation_message_bubble_view.cc View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Evan Stade
3 years, 7 months ago (2017-05-18 21:42:08 UTC) #6
Peter Kasting
LGTM
3 years, 7 months ago (2017-05-18 22:04:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893573004/1
3 years, 7 months ago (2017-05-18 22:25:45 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 22:38:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2bb48c8a1af8c61799d7a1e3031d...

Powered by Google App Engine
This is Rietveld 408576698