Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: pkg/front_end/lib/src/fasta/dill/dill_target.dart

Issue 2893563003: Rename buildOutline() and separate 'build' and 'writeProgram()'. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/compile_platform.dart ('k') | pkg/front_end/lib/src/fasta/fasta.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/dill/dill_target.dart
diff --git a/pkg/front_end/lib/src/fasta/dill/dill_target.dart b/pkg/front_end/lib/src/fasta/dill/dill_target.dart
index 197e79915f9c88995064496b78b0b3bb6d413e83..9a51575c051ee82b4f261834ee764fe4d4acc299 100644
--- a/pkg/front_end/lib/src/fasta/dill/dill_target.dart
+++ b/pkg/front_end/lib/src/fasta/dill/dill_target.dart
@@ -34,16 +34,17 @@ class DillTarget extends TargetImplementation {
internalError("Unsupported operation.");
}
- Future<Null> writeProgram(Uri uri) {
+ @override
+ Future<Null> buildProgram() {
return internalError("not implemented.");
}
@override
- Future<Null> computeOutline() async {
- if (loader.libraries.isEmpty) return null;
- await loader.buildOutlines();
+ Future<Null> buildOutlines() async {
+ if (loader.libraries.isNotEmpty) {
+ await loader.buildOutlines();
+ }
isLoaded = true;
- return null;
}
DillLibraryBuilder createLibraryBuilder(Uri uri, Uri fileUri) {
« no previous file with comments | « pkg/front_end/lib/src/fasta/compile_platform.dart ('k') | pkg/front_end/lib/src/fasta/fasta.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698