Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: pkg/front_end/lib/src/fasta/fasta.dart

Issue 2893563003: Rename buildOutline() and separate 'build' and 'writeProgram()'. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/fasta.dart
diff --git a/pkg/front_end/lib/src/fasta/fasta.dart b/pkg/front_end/lib/src/fasta/fasta.dart
index 2c39693f19c9420cedc36153c252e0df6c5e4d13..01b4e27cc3e2739421e4ddb4cc4c622059d6a5bb 100644
--- a/pkg/front_end/lib/src/fasta/fasta.dart
+++ b/pkg/front_end/lib/src/fasta/fasta.dart
@@ -144,8 +144,8 @@ class CompileTask {
} else {
inputError(uri, -1, "Unexpected input: $uri");
}
- await dillTarget.computeOutline();
- await kernelTarget.computeOutline();
+ await dillTarget.buildOutlines();
+ await kernelTarget.buildOutlines();
await kernelTarget.writeOutline(output);
if (c.options.dumpIr && output != null) {
kernelTarget.dumpIr();
@@ -157,6 +157,7 @@ class CompileTask {
KernelTarget kernelTarget = await buildOutline();
if (exitCode != 0) return null;
Uri uri = c.options.output;
+ await kernelTarget.buildProgram();
await kernelTarget.writeProgram(uri,
dumpIr: c.options.dumpIr, verify: c.options.verify);
return uri;
@@ -194,9 +195,9 @@ Future<CompilationResult> parseScriptInFileSystem(
final KernelTarget kernelTarget =
new KernelTarget(fileSystem, dillTarget, uriTranslator, strongMode);
kernelTarget.read(fileName);
- await dillTarget.computeOutline();
- await kernelTarget.computeOutline();
- program = await kernelTarget.writeProgram(null);
+ await dillTarget.buildOutlines();
+ await kernelTarget.buildOutlines();
+ program = await kernelTarget.buildProgram();
if (kernelTarget.errors.isNotEmpty) {
return new CompilationResult.errors(kernelTarget.errors
.map((err) => err.toString())
@@ -267,7 +268,7 @@ Future writeDepsFile(Uri script, Uri depsFile, Uri output,
dillTarget, uriTranslator, false, c.uriToSource);
kernelTarget.read(script);
- await dillTarget.computeOutline();
+ await dillTarget.buildOutlines();
await kernelTarget.loader.buildOutlines();
await kernelTarget.writeDepsFile(output, depsFile,
extraDependencies: extraDependencies);
« no previous file with comments | « pkg/front_end/lib/src/fasta/dill/dill_target.dart ('k') | pkg/front_end/lib/src/fasta/kernel/kernel_target.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698