Rename buildOutline() and separate 'build' and 'writeProgram()'.

Rename buildOutline() and separate 'build' and 'writeProgram()'.

Also rename KernelTarget.program to _program to prevent clients from
reaching into internals. I think eventually we want to make more
stuff private. And rationalize errors handling. And... many things :-)


R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/06e9b4b5034bde81e0a15c59dcfff2233f0e78f4

[Siggi Cherem (dart-lang), 2017-05-17 17:28:05]

lgtm, though I know Peter has some reservations on using _private members in
fasta. I'll let him chime in on that.

I personally do like using it, especially for things that are fully encapsulated
like the _program property. However, if he feels strongly about not using it
here, I'm OK tabling that discussion for later and keeping it public until we
figure out the general style/direction of the codebase.

Up to you on how to proceed at this moment:
 * wait for Peter before landing, or
 * switch it back to public in this CL, land the build* changes, and move the
other change to a separate CL, or
 * land it as you have it in this CL with the caveat that we might change it
again tomorrow after his comments

[scheglov, 2017-05-17 18:10:13]

Description was changed from

==========
Rename buildOutline() and separate 'build' and 'writeProgram()'.

Also rename KernelTarget.program to _program to prevent clients from
reaching into internals. I think eventually we want to make more
stuff private. And rationalize errors handling. And... many things :-)


R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Rename buildOutline() and separate 'build' and 'writeProgram()'.

Also rename KernelTarget.program to _program to prevent clients from
reaching into internals. I think eventually we want to make more
stuff private. And rationalize errors handling. And... many things :-)


R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/06e9b4b5034bde81e0a15c59dcfff2233f0e78f4
==========

[scheglov, 2017-05-17 18:10:16]

Committed patchset #1 (id:1) manually as
06e9b4b5034bde81e0a15c59dcfff2233f0e78f4 (presubmit successful).

[ahe, 2017-05-22 13:47:07]

Please try to keep stylistic changes to a minimum. It's not productive for any
of that code oscillate between stylistic differences of opinion. The best way to
approach this is that whoever writes the code initially picks the style they
prefer, and subsequent editors follow suit. 

If you think we need to change our style in general, please suggest that we do
so in our weekly meetings so we can discuss it.