Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2893483004: Revert of Avoid unnecessary registry/plist reads (hundreds of them) by caching the brand code. (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Avoid unnecessary registry/plist reads (hundreds of them) by caching the brand code. (patchset #5 id:80001 of https://codereview.chromium.org/2891453004/ ) Reason for revert: Broke official builds due to chromium-style compiler error. Original issue's description: > Avoid unnecessary registry/plist reads (hundreds of them) by caching the brand code. > > BUG=723072 > > Review-Url: https://codereview.chromium.org/2891453004 > Cr-Commit-Position: refs/heads/master@{#472622} > Committed: https://chromium.googlesource.com/chromium/src/+/4c703a924fc505015240e1ee859c6a9340d4be2e TBR=pkasting@chromium.org,grt@chromium.org,borisv@chromium.org,borisv@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=723072 Review-Url: https://codereview.chromium.org/2893483004 Cr-Commit-Position: refs/heads/master@{#472624} Committed: https://chromium.googlesource.com/chromium/src/+/c295631f2dda9cc64b1b9becd12527c12efe8802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M chrome/browser/search_engines/ui_thread_search_terms_data.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Lei Zhang
Created Revert of Avoid unnecessary registry/plist reads (hundreds of them) by caching the brand code.
3 years, 7 months ago (2017-05-18 01:57:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893483004/1
3 years, 7 months ago (2017-05-18 01:59:33 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 02:00:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c295631f2dda9cc64b1b9becd125...

Powered by Google App Engine
This is Rietveld 408576698