cros: AutomationManagerAura::SendEvent crash fix

cros: AutomationManagerAura::SendEvent crash fix

Changes:
When I am working on suspend/resume media sessions, I could hit AutomationManagerAura::SendEvent crash. It is because current_tree_serializer_ can be NULL with nullptr access (->).

BUG=721557
TEST=tested with WIP CL: https://codereview.chromium.org/2821303004/, crash doesn't happen any more.

Review-Url: https://codereview.chromium.org/2893473002
Cr-Commit-Position: refs/heads/master@{#472359}
Committed: https://chromium.googlesource.com/chromium/src/+/39ebcbc314998f76d3fd56cdf633ab29ef809d4c

[Qiang(Joe) Xu, 2017-05-16 23:24:28]

Description was changed from

==========
cros: automation_manager_aura SendEvent crash fix

BUG=721557
==========

to

==========
cros: automation_manager_aura SendEvent crash fix

Changes:
When I am working on suspend/resume media sessions, I could hit
AutomationManagerAura::SendEvent crash. It is because current_tree_serializer_
can be NULL with nullptr access (->).

BUG=721557
==========

[Qiang(Joe) Xu, 2017-05-16 23:24:28]

warx@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[Qiang(Joe) Xu, 2017-05-16 23:25:43]

Description was changed from

==========
cros: automation_manager_aura SendEvent crash fix

Changes:
When I am working on suspend/resume media sessions, I could hit
AutomationManagerAura::SendEvent crash. It is because current_tree_serializer_
can be NULL with nullptr access (->).

BUG=721557
==========

to

==========
cros: AutomationManagerAura::SendEvent crash fix

Changes:
When I am working on suspend/resume media sessions, I could hit
AutomationManagerAura::SendEvent crash. It is because current_tree_serializer_
can be NULL with nullptr access (->).

BUG=721557
TEST=tested with WIP CL: https://codereview.chromium.org/2821303004/, crash
doesn't happen any more.
==========

[Qiang(Joe) Xu, 2017-05-16 23:26:40]

Hi Dominic,

I have debug build stack trace updated in the crbug. Here is my quick fix. Does
this sound good to you?

Thanks!

[dmazzoni, 2017-05-17 05:13:01]

lgtm

https://codereview.chromium.org/2893473002/diff/1/chrome/browser/ui/aura/acce...
File chrome/browser/ui/aura/accessibility/automation_manager_aura.cc (right):

https://codereview.chromium.org/2893473002/diff/1/chrome/browser/ui/aura/acce...
chrome/browser/ui/aura/accessibility/automation_manager_aura.cc:151: if
(!current_tree_serializer_ ||
Thanks for debugging! Looks like SendEvent was being
called before current_tree_serializer_ was first initialized.

Maybe move it up to the top, no log needed:

if (!current_tree_serializer_)
  return;

[Qiang(Joe) Xu, 2017-05-17 05:36:17]

https://codereview.chromium.org/2893473002/diff/1/chrome/browser/ui/aura/acce...
File chrome/browser/ui/aura/accessibility/automation_manager_aura.cc (right):

https://codereview.chromium.org/2893473002/diff/1/chrome/browser/ui/aura/acce...
chrome/browser/ui/aura/accessibility/automation_manager_aura.cc:151: if
(!current_tree_serializer_ ||
On 2017/05/17 05:13:01, dmazzoni wrote:
> Thanks for debugging! Looks like SendEvent was being
> called before current_tree_serializer_ was first initialized.
> 
> Maybe move it up to the top, no log needed:
> 
> if (!current_tree_serializer_)
>   return;

Done.

[Qiang(Joe) Xu, 2017-05-17 05:36:22]

The CQ bit was checked by warx@chromium.org

[Qiang(Joe) Xu, 2017-05-17 05:36:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2893473002/#ps20001
(title: "feedback")

[commit-bot: I haz the power, 2017-05-17 05:37:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 06:53:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494999382030400,
"parent_rev": "90e87f4bb986def04af8f8310cd495bfbead49bb", "commit_rev":
"39ebcbc314998f76d3fd56cdf633ab29ef809d4c"}

[commit-bot: I haz the power, 2017-05-17 06:53:34]

Description was changed from

==========
cros: AutomationManagerAura::SendEvent crash fix

Changes:
When I am working on suspend/resume media sessions, I could hit
AutomationManagerAura::SendEvent crash. It is because current_tree_serializer_
can be NULL with nullptr access (->).

BUG=721557
TEST=tested with WIP CL: https://codereview.chromium.org/2821303004/, crash
doesn't happen any more.
==========

to

==========
cros: AutomationManagerAura::SendEvent crash fix

Changes:
When I am working on suspend/resume media sessions, I could hit
AutomationManagerAura::SendEvent crash. It is because current_tree_serializer_
can be NULL with nullptr access (->).

BUG=721557
TEST=tested with WIP CL: https://codereview.chromium.org/2821303004/, crash
doesn't happen any more.

Review-Url: https://codereview.chromium.org/2893473002
Cr-Commit-Position: refs/heads/master@{#472359}
Committed:
https://chromium.googlesource.com/chromium/src/+/39ebcbc314998f76d3fd56cdf633...
==========

[commit-bot: I haz the power, 2017-05-17 06:53:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/39ebcbc314998f76d3fd56cdf633...