Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2893433004: Settings: Manage other users -> Manage other people (Closed)

Created:
3 years, 7 months ago by stevenjb
Modified:
3 years, 7 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings: Manage other users -> Manage other people BUG=719552 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2893433004 Cr-Commit-Position: refs/heads/master@{#473632} Committed: https://chromium.googlesource.com/chromium/src/+/2ac0511d28994ccd83280e6c93f773ed6876a237

Patch Set 1 #

Patch Set 2 : Make AddUserStrings CrOS only #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M chrome/app/settings_strings.grdp View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 2 4 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 27 (15 generated)
stevenjb
3 years, 7 months ago (2017-05-17 17:33:19 UTC) #3
dschuyler
lgtm
3 years, 7 months ago (2017-05-17 20:50:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893433004/1
3 years, 7 months ago (2017-05-17 21:38:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/421684)
3 years, 7 months ago (2017-05-17 22:00:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893433004/20001
3 years, 7 months ago (2017-05-17 22:07:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/429868)
3 years, 7 months ago (2017-05-18 02:59:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893433004/20001
3 years, 7 months ago (2017-05-18 15:48:28 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/430635)
3 years, 7 months ago (2017-05-18 20:09:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893433004/40001
3 years, 7 months ago (2017-05-22 16:56:15 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/220535)
3 years, 7 months ago (2017-05-22 17:43:05 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893433004/40001
3 years, 7 months ago (2017-05-22 17:45:42 UTC) #24
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 18:34:41 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2ac0511d28994ccd83280e6c93f7...

Powered by Google App Engine
This is Rietveld 408576698