Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2893363002: Revert of [scheduler] Move task alignment into WakeUpBudgetPool. (Closed)

Created:
3 years, 7 months ago by Marijn Kruisselbrink
Modified:
3 years, 7 months ago
CC:
chromium-reviews, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [scheduler] Move task alignment into WakeUpBudgetPool. (patchset #5 id:80001 of https://codereview.chromium.org/2896603002/ ) Reason for revert: Regresses sizes on https://build.chromium.org/p/chromium/buildstatus?builder=Linux%20x64&number=40173 (due to include of iostream) Original issue's description: > [scheduler] Move task alignment into WakeUpBudgetPool. > > This fixes the regression where real-world throttling regressed to > two-seconds task alignment instead of one-second alignment. > This patch also improves test coverage for background throttling. > > BUG=722410 > > Review-Url: https://codereview.chromium.org/2896603002 > Cr-Commit-Position: refs/heads/master@{#473609} > Committed: https://chromium.googlesource.com/chromium/src/+/188fc72030f13187af5cff7e9802f3abebdea017 TBR=skyostil@chromium.org,alexclarke@chromium.org,altimin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=722410 Review-Url: https://codereview.chromium.org/2893363002 Cr-Commit-Position: refs/heads/master@{#473615} Committed: https://chromium.googlesource.com/chromium/src/+/8e701ae2e5e345d6938c566dc4b9d6ac7c397b20

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
Marijn Kruisselbrink
Created Revert of [scheduler] Move task alignment into WakeUpBudgetPool.
3 years, 7 months ago (2017-05-22 17:49:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893363002/1
3 years, 7 months ago (2017-05-22 17:50:26 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 17:51:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8e701ae2e5e345d6938c566dc4b9...

Powered by Google App Engine
This is Rietveld 408576698