Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2893353003: New text for sign-in promo in settings (Closed)

Created:
3 years, 7 months ago by jlebel
Modified:
3 years, 7 months ago
Reviewers:
msarda
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, srahim+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

New text for sign-in promo in settings Changing from: To get your settings on all your devices, sign in to Chrome. to: Sign in to Chrome to get your bookmarks, passwords, and more on all your devices. BUG=723547 Review-Url: https://codereview.chromium.org/2893353003 Cr-Commit-Position: refs/heads/master@{#473708} Committed: https://chromium.googlesource.com/chromium/src/+/0946bcce0307295e466335001a51fc0e6bc4e8fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ios/chrome/app/strings/ios_chromium_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/app/strings/ios_google_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
jlebel
Hello Mihai, Can you review this very small patch? Thanks,
3 years, 7 months ago (2017-05-22 17:34:31 UTC) #2
msarda
lgtm
3 years, 7 months ago (2017-05-22 21:15:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893353003/1
3 years, 7 months ago (2017-05-22 21:27:07 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 21:39:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0946bcce0307295e466335001a51...

Powered by Google App Engine
This is Rietveld 408576698