Adds type information to the NetworkStateNotifier. Also allows for registration of observers.

public/platform/WebNetworkConnection.h

Index: public/platform/WebNetworkConnection.h
diff --git a/public/platform/WebCanvas.h b/public/platform/WebNetworkConnection.h
similarity index 83%
copy from public/platform/WebCanvas.h
copy to public/platform/WebNetworkConnection.h
index d0de44c6e4f57fcadb48288e7b1baf1216c93736..5acc6b54263d65dfef5f20bd4f1f77f0a2ec0843 100644
--- a/public/platform/WebCanvas.h
+++ b/public/platform/WebNetworkConnection.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2009 Google Inc. All rights reserved.
+ * Copyright (C) 2014 Google Inc. All rights reserved.

[adamk, 2014/05/20 15:00:36]

New files should use the short version of the copyright header (see, e.g.,
WebBatteryStatus.h)

  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
@@ -28,16 +28,25 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef WebCanvas_h
-#define WebCanvas_h
+#ifndef WebNetworkConnection_h
+#define WebNetworkConnection_h
 
 #include "WebCommon.h"
-
-class SkCanvas;
+#include "WebString.h"

[adamk, 2014/05/20 15:00:36]

Not clear why you need WebString here

[jkarlin, 2014/05/20 16:20:23]

Done.

 
 namespace blink {
 
-typedef SkCanvas WebCanvas;
+struct WebNetworkConnection {

[adamk, 2014/05/20 15:00:36]

Can you add a comment here pointing at the spec defining these types? I can
imagine someone not realizing that these correspond 1:1 with the spec.

[jkarlin, 2014/05/20 16:20:23]

Done.

+

[adamk, 2014/05/20 15:00:36]

Nit: remove blank line

[jkarlin, 2014/05/20 16:20:23]

Done.

+    enum ConnectionType {
+        Cellular = 0,
+        Bluetooth,
+        Ethernet,
+        Wifi,
+        Other,
+        None
+    };
+};
 
 } // namespace blink