public/platform/WebNetworkConnection.h - Issue 289333003: Adds type information to the NetworkStateNotifier. Also allows for registration of observers.

Side by Side Diff: public/platform/WebNetworkConnection.h

Issue 289333003: Adds type information to the NetworkStateNotifier. Also allows for registration of observers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Thread safe observer list Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009 Google Inc. All rights reserved.	2 * Copyright (C) 2014 Google Inc. All rights reserved.
	adamk 2014/05/20 15:00:36 New files should use the short version of the copy New files should use the short version of the copyright header (see, e.g., WebBatteryStatus.h)
3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

11 * copyright notice, this list of conditions and the following disclaimer	11 * copyright notice, this list of conditions and the following disclaimer

12 * in the documentation and/or other materials provided with the	12 * in the documentation and/or other materials provided with the

13 * distribution.	13 * distribution.

14 * * Neither the name of Google Inc. nor the names of its	14 * * Neither the name of Google Inc. nor the names of its

15 * contributors may be used to endorse or promote products derived from	15 * contributors may be used to endorse or promote products derived from

16 * this software without specific prior written permission.	16 * this software without specific prior written permission.

17 *	17 *

18 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS	18 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS

19 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT	19 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT

20 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR	20 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR

21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT	21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT

22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,	22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,

23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT	23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT

24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,	24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,

25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY	25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY

26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT	26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE	27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.	28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

29 */	29 */

30	30

31 #ifndef WebCanvas_h	31 #ifndef WebNetworkConnection_h

32 #define WebCanvas_h	32 #define WebNetworkConnection_h

33	33

34 #include "WebCommon.h"	34 #include "WebCommon.h"

35	35 #include "WebString.h"
	adamk 2014/05/20 15:00:36 Not clear why you need WebString here Not clear why you need WebString here jkarlin 2014/05/20 16:20:23 Done. Show quoted text On 2014/05/20 15:00:36, adamk wrote: > Not clear why you need WebString here Done.
36 class SkCanvas;

37	36

38 namespace blink {	37 namespace blink {

39	38

40 typedef SkCanvas WebCanvas;	39 struct WebNetworkConnection {
	adamk 2014/05/20 15:00:36 Can you add a comment here pointing at the spec de Can you add a comment here pointing at the spec defining these types? I can imagine someone not realizing that these correspond 1:1 with the spec. jkarlin 2014/05/20 16:20:23 Done. Show quoted text On 2014/05/20 15:00:36, adamk wrote: > Can you add a comment here pointing at the spec defining these types? I can > imagine someone not realizing that these correspond 1:1 with the spec. Done.
	40
	adamk 2014/05/20 15:00:36 Nit: remove blank line Nit: remove blank line jkarlin 2014/05/20 16:20:23 Done. Show quoted text On 2014/05/20 15:00:36, adamk wrote: > Nit: remove blank line Done.
	41 enum ConnectionType {

	42 Cellular = 0,

	43 Bluetooth,

	44 Ethernet,

	45 Wifi,

	46 Other,

	47 None

	48 };

	49 };

41	50

42 } // namespace blink	51 } // namespace blink

43	52

44 #endif	53 #endif

OLD	NEW

« Source/web/WebNetworkStateNotifier.cpp ('K') | « Source/web/WebNetworkStateNotifier.cpp ('k') | public/web/WebNetworkStateNotifier.h » ('j') | no next file with comments »