Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2893323002: [Mac] Force invalidate bookmark bar layout on node change (Closed)

Created:
3 years, 7 months ago by lgrey
Modified:
3 years, 7 months ago
Reviewers:
Elly Fong-Jones
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Force-invalidate bookmark bar layout on node change ...if the node is visible in the bookmark bar. This corrects a bug where, if a bookmark was renamed but button offsets and count were unaffected (for example, the button is last on the bar and there's no overflow), the button wouldn't update to the new title. BUG=724201 Review-Url: https://codereview.chromium.org/2893323002 Cr-Commit-Position: refs/heads/master@{#473592} Committed: https://chromium.googlesource.com/chromium/src/+/f04717fc7e1e19ed51028bab3b1008a20962a9dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
lgrey
PTAL :)
3 years, 7 months ago (2017-05-22 15:44:50 UTC) #3
Elly Fong-Jones
lgtm
3 years, 7 months ago (2017-05-22 15:56:43 UTC) #6
lgrey
Thanks!
3 years, 7 months ago (2017-05-22 16:16:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893323002/1
3 years, 7 months ago (2017-05-22 16:16:44 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 16:23:41 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f04717fc7e1e19ed51028bab3b10...

Powered by Google App Engine
This is Rietveld 408576698