Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2893263002: [turbofan] Add Symbol feedback to Equal/StrictEqual. (Closed)

Created:
3 years, 7 months ago by Benedikt Meurer
Modified:
3 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add Symbol feedback to Equal/StrictEqual. Introduce a new Symbol comparison feedback bit in the lattice and collect that feedback on Equal/StrictEqual in Ignition. Utilize this feedback in TurboFan by adding a dedicated CheckSymbol operator to check for symbol inputs. This way we can optimize Symbol comparison where TurboFan doesn't know anything statically about either side, or abstract equality comparisons where TurboFan doesn't statically know anything about one side. BUG=v8:6278, v8:6344, v8:6423 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2893263002 Cr-Commit-Position: refs/heads/master@{#45455} Committed: https://chromium.googlesource.com/v8/v8/+/d9e432973b4d7d2fe7a8c9b465b83a6f34f566ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -46 lines) Patch
M src/code-stub-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 7 chunks +73 lines, -20 lines 0 comments Download
M src/compiler/effect-control-linearizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/js-type-hint-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 5 chunks +35 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 4 chunks +19 lines, -24 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/deoptimize-reason.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/feedback-vector-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/globals.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/type-hints.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/type-hints.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/type-info.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 7 months ago (2017-05-22 11:34:48 UTC) #1
Jarin
lgtm
3 years, 7 months ago (2017-05-22 11:49:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893263002/1
3 years, 7 months ago (2017-05-22 11:50:20 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 12:07:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d9e432973b4d7d2fe7a8c9b465b83a6f34f...

Powered by Google App Engine
This is Rietveld 408576698