color: Add ColorCanvasExtensions runtime flag

color: Add ColorCanvasExtensions runtime flag

These features being developed behind --enable-color-correct-rendering
and --enable-experimental-canvas-features.

We're turning on  --enable-color-correct-rendering for all layout tests,
some of which also use --enable-experimental-canvas-features, but do
not want to opt in to new canvas behaviors (at least yet).

To avoid this, use the Blink feature flag ColorCanvasExtensions. While
we're in the neighborhood, pull out the uses of the flag
--enable-color-correct-rendering-default-mode and related code.

BUG=724733
Review-Url: https://codereview.chromium.org/2893243003
Cr-Commit-Position: refs/heads/master@{#474921}
Committed: https://chromium.googlesource.com/chromium/src/+/b1e300b0f88b6a65a87c9b27cd3e327499c25e86

[ccameron, 2017-05-22 21:59:23]

ccameron@chromium.org changed reviewers:
+ junov@chromium.org

[ccameron, 2017-05-22 21:59:23]

ptal -- this is needed to start enabling color-correct-rendering for layout
tests

[ccameron, 2017-05-22 22:47:12]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 22:47:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 01:06:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 01:06:51]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Justin Novosad, 2017-05-23 19:20:28]

Thanks for the drive-by clean-ups.

https://codereview.chromium.org/2893243003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
(left):

https://codereview.chromium.org/2893243003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp:1166:
TEST_F(CanvasRenderingContext2DTest,
Why is this test being removed?

https://codereview.chromium.org/2893243003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp:1184:
TEST_F(CanvasRenderingContext2DTest,
and this one?

[Justin Novosad, 2017-05-23 19:21:09]

cc: zakerinasab (FYI)

[ccameron, 2017-05-23 19:23:49]

Thanks -- updated comments WRT tests

https://codereview.chromium.org/2893243003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
(left):

https://codereview.chromium.org/2893243003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp:1166:
TEST_F(CanvasRenderingContext2DTest,
On 2017/05/23 19:20:28, Justin Novosad wrote:
> Why is this test being removed?

This is testing DrawImageColorBehavior(), but that function had no callers, and
has been removed.

Also, the behavior for image content is:
- if no color management enabled, then "transform to global target"
- in all other cases, tag the image

So the behavior that this is testing (that images should be pre-transformed) is
not applicable anymore.

https://codereview.chromium.org/2893243003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp:1184:
TEST_F(CanvasRenderingContext2DTest,
On 2017/05/23 19:20:28, Justin Novosad wrote:
> and this one?

(same deal -- the behavior will be always be "tag" as soon as we enable color
correct rendering)

[ccameron, 2017-05-23 19:28:15]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 19:28:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 19:37:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 19:37:17]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2017-05-23 19:43:05]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 19:43:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Novosad, 2017-05-23 20:57:56]

lgtm

[ccameron, 2017-05-23 21:00:35]

ccameron@chromium.org changed reviewers:
+ avi@chromium.org, pdr@chromium.org, tsepez@chromium.org

[ccameron, 2017-05-23 21:00:36]

+tsepez for IPC (renamed variable)
+pdr for WebKit/Source/web and WebKit/public OWNER
+avi for content/ OWNER

[Avi (use Gerrit), 2017-05-23 21:05:12]

lgtm

[Tom Sepez, 2017-05-23 22:02:26]

lgtm

RS

[commit-bot: I haz the power, 2017-05-23 22:04:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 22:04:01]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pdr., 2017-05-23 22:50:41]

Two quick questions:

ExperimentalCanvasFeatures is listed as "test" which should mean it's already on
for all layouttests, right? I don't understand the comment about needing to
enable ColorCorrectRendering without ExperimentalCanvasFeatures.

Do we need a new command line flag for this feature or can we use
--enable-blink-features=ColorCanvasExtensions?

[ccameron, 2017-05-23 23:18:55]

On 2017/05/23 22:50:41, pdr (OOO Jury Duty). wrote:
> Two quick questions:
> 
> ExperimentalCanvasFeatures is listed as "test" which should mean it's already
on
> for all layouttests, right? I don't understand the comment about needing to
> enable ColorCorrectRendering without ExperimentalCanvasFeatures.
> 
> Do we need a new command line flag for this feature or can we use
> --enable-blink-features=ColorCanvasExtensions?

Oh -- you're right -- I can just use
--enable-blink-features=ColorCanvasExtensions.

[ccameron, 2017-05-24 23:14:06]

Description was changed from

==========
color: Add --enable-color-canvas-extensions flag

These features being developed behind --enable-color-correct-rendering
and --enable-experimental-canvas-features.

We're turning on  --enable-color-correct-rendering for all layout tests,
some of which also use --enable-experimental-canvas-features, but do
not want to opt in to new canvas behaviors.

To avoid this, use the flag --enable-color-canvas-extensions. While
we're in the neighborhood, pull out the uses of the flag
--enable-color-correct-rendering-default-mode and related code.

BUG=724733
==========

to

==========
color: Add ColorCanvasExtensions runtime flag

These features being developed behind --enable-color-correct-rendering
and --enable-experimental-canvas-features.

We're turning on  --enable-color-correct-rendering for all layout tests,
some of which also use --enable-experimental-canvas-features, but do
not want to opt in to new canvas behaviors (at least yet).

To avoid this, use the Blink feature flag ColorCanvasExtensions. While
we're in the neighborhood, pull out the uses of the flag
--enable-color-correct-rendering-default-mode and related code.

BUG=724733
==========

[ccameron, 2017-05-24 23:15:50]

ccameron@chromium.org changed reviewers:
+ dglazkov@chromium.org

[ccameron, 2017-05-24 23:15:51]

+dglazkov@ 'cause pdr@ vanished for jury duty.

dglazkov, can you OWNER third_party/WebKit/Source/web/ and
third_party/WebKit/Source/web/?

[haraken, 2017-05-24 23:47:45]

On 2017/05/24 23:15:51, ccameron wrote:
> +dglazkov@ 'cause pdr@ vanished for jury duty.
> 
> dglazkov, can you OWNER third_party/WebKit/Source/web/ and
> third_party/WebKit/Source/web/?

LGTM

[ccameron, 2017-05-24 23:50:04]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-05-24 23:50:05]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
avi@chromium.org, junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2893243003/#ps80001
(title: "Remove runtime features too")

[commit-bot: I haz the power, 2017-05-24 23:50:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 23:53:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 23:53:57]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pdr., 2017-05-25 00:06:55]

On 2017/05/24 at 23:15:51, ccameron wrote:
> +dglazkov@ 'cause pdr@ vanished for jury duty.
> 
> dglazkov, can you OWNER third_party/WebKit/Source/web/ and
third_party/WebKit/Source/web/?

Apologies for the holdup, LGTM here too.

[ccameron, 2017-05-25 00:13:04]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-05-25 00:13:05]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
junov@chromium.org, tsepez@chromium.org, haraken@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2893243003/#ps100001
(title: "Rebase and resolve")

[commit-bot: I haz the power, 2017-05-25 00:14:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 02:13:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 02:13:50]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ccameron, 2017-05-25 19:34:18]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-05-25 19:34:18]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
junov@chromium.org, tsepez@chromium.org, haraken@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2893243003/#ps120001
(title: "Make not-experimental")

[commit-bot: I haz the power, 2017-05-25 19:34:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 21:39:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 21:39:13]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2017-05-25 23:05:58]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-05-25 23:05:58]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
junov@chromium.org, tsepez@chromium.org, haraken@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2893243003/#ps140001
(title: "Update webkit_unit_tests to use new flags")

[commit-bot: I haz the power, 2017-05-25 23:06:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 02:51:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 02:51:06]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2017-05-26 03:35:19]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-05-26 03:36:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 05:24:31]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1495769719782210,
"parent_rev": "10cfdc03a41bf1808feaacb0a6648a6e6dc6d47d", "commit_rev":
"b1e300b0f88b6a65a87c9b27cd3e327499c25e86"}

[commit-bot: I haz the power, 2017-05-26 05:24:48]

Description was changed from

==========
color: Add ColorCanvasExtensions runtime flag

These features being developed behind --enable-color-correct-rendering
and --enable-experimental-canvas-features.

We're turning on  --enable-color-correct-rendering for all layout tests,
some of which also use --enable-experimental-canvas-features, but do
not want to opt in to new canvas behaviors (at least yet).

To avoid this, use the Blink feature flag ColorCanvasExtensions. While
we're in the neighborhood, pull out the uses of the flag
--enable-color-correct-rendering-default-mode and related code.

BUG=724733
==========

to

==========
color: Add ColorCanvasExtensions runtime flag

These features being developed behind --enable-color-correct-rendering
and --enable-experimental-canvas-features.

We're turning on  --enable-color-correct-rendering for all layout tests,
some of which also use --enable-experimental-canvas-features, but do
not want to opt in to new canvas behaviors (at least yet).

To avoid this, use the Blink feature flag ColorCanvasExtensions. While
we're in the neighborhood, pull out the uses of the flag
--enable-color-correct-rendering-default-mode and related code.

BUG=724733

Review-Url: https://codereview.chromium.org/2893243003
Cr-Commit-Position: refs/heads/master@{#474921}
Committed:
https://chromium.googlesource.com/chromium/src/+/b1e300b0f88b6a65a87c9b27cd3e...
==========

[commit-bot: I haz the power, 2017-05-26 05:24:49]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/b1e300b0f88b6a65a87c9b27cd3e...