Source/core/rendering/InlineTextBox.cpp - Issue 289323003: Move markerlists to Oilpan heap and remove finalizer from DocumentMarkerController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/InlineTextBox.cpp

Issue 289323003: Move markerlists to Oilpan heap and remove finalizer from DocumentMarkerController (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Move DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/InlineTextBox.cpp

diff --git a/Source/core/rendering/InlineTextBox.cpp b/Source/core/rendering/InlineTextBox.cpp

index 147733f6e5e9c2866b1972466acd9e7d7a515d74..fee393d6e8be5d6c59974f98f8dbd361831c32f4 100644

--- a/Source/core/rendering/InlineTextBox.cpp

+++ b/Source/core/rendering/InlineTextBox.cpp

@@ -1311,8 +1311,8 @@ void InlineTextBox::paintDocumentMarkers(GraphicsContext* pt, const FloatPoint&

if (!renderer().node())

return;

- Vector<DocumentMarker*> markers = renderer().document().markers().markersFor(renderer().node());

- Vector<DocumentMarker*>::const_iterator markerIt = markers.begin();

+ WillBeHeapVector<DocumentMarker*> markers = renderer().document().markers().markersFor(renderer().node());

+ WillBeHeapVector<DocumentMarker*>::const_iterator markerIt = markers.begin();

// Give any document markers that touch this run a chance to draw before the text has been drawn.

// Note end() points at the last char, not one past it like endOffset and ranges do.

« no previous file with comments | « Source/core/page/EventHandler.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »