Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: Source/core/testing/Internals.cpp

Issue 289323003: Move markerlists to Oilpan heap and remove finalizer from DocumentMarkerController (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Move DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/InlineTextBox.cpp ('k') | Source/platform/geometry/IntPoint.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/testing/Internals.cpp
diff --git a/Source/core/testing/Internals.cpp b/Source/core/testing/Internals.cpp
index 3ebcb6eb92b4ba70c5108a41298e810cf3b17f98..93b037891c3a20a1c5dd3f7b607d659109fe5b75 100644
--- a/Source/core/testing/Internals.cpp
+++ b/Source/core/testing/Internals.cpp
@@ -805,10 +805,10 @@ unsigned Internals::activeMarkerCountForNode(Node* node, ExceptionState& excepti
// Only TextMatch markers can be active.
DocumentMarker::MarkerType markerType = DocumentMarker::TextMatch;
- Vector<DocumentMarker*> markers = node->document().markers().markersFor(node, markerType);
+ WillBeHeapVector<DocumentMarker*> markers = node->document().markers().markersFor(node, markerType);
unsigned activeMarkerCount = 0;
- for (Vector<DocumentMarker*>::iterator iter = markers.begin(); iter != markers.end(); ++iter) {
+ for (WillBeHeapVector<DocumentMarker*>::iterator iter = markers.begin(); iter != markers.end(); ++iter) {
if ((*iter)->activeMatch())
activeMarkerCount++;
}
@@ -829,7 +829,7 @@ DocumentMarker* Internals::markerAt(Node* node, const String& markerType, unsign
return 0;
}
- Vector<DocumentMarker*> markers = node->document().markers().markersFor(node, markerTypes);
+ WillBeHeapVector<DocumentMarker*> markers = node->document().markers().markersFor(node, markerTypes);
if (markers.size() <= index)
return 0;
return markers[index];
« no previous file with comments | « Source/core/rendering/InlineTextBox.cpp ('k') | Source/platform/geometry/IntPoint.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698