Source/core/editing/SpellCheckRequester.cpp - Issue 289323003: Move markerlists to Oilpan heap and remove finalizer from DocumentMarkerController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/SpellCheckRequester.cpp

Issue 289323003: Move markerlists to Oilpan heap and remove finalizer from DocumentMarkerController (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Move DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/SpellCheckRequester.cpp

diff --git a/Source/core/editing/SpellCheckRequester.cpp b/Source/core/editing/SpellCheckRequester.cpp

index 47fdc02ff9e79fc1b6ef49e9cd428ed19cdc0025..2d43474cb532279a71f72548fcf45b3c0c82f344 100644

--- a/Source/core/editing/SpellCheckRequester.cpp

+++ b/Source/core/editing/SpellCheckRequester.cpp

@@ -68,7 +68,7 @@ PassRefPtr<SpellCheckRequest> SpellCheckRequest::create(TextCheckingTypeMask tex

if (!text.length())

return PassRefPtr<SpellCheckRequest>();

- const Vector<DocumentMarker*>& markers = checkingRange->ownerDocument().markers().markersInRange(checkingRange.get(), DocumentMarker::SpellCheckClientMarkers());

+ const WillBeHeapVector<DocumentMarker*>& markers = checkingRange->ownerDocument().markers().markersInRange(checkingRange.get(), DocumentMarker::SpellCheckClientMarkers());

Vector<uint32_t> hashes(markers.size());

Vector<unsigned> offsets(markers.size());

for (size_t i = 0; i < markers.size(); i++) {

« no previous file with comments | « Source/core/editing/CompositeEditCommand.cpp ('k') | Source/core/editing/SpellChecker.cpp » ('j') | no next file with comments »