Source/core/editing/SpellChecker.cpp - Issue 289323003: Move markerlists to Oilpan heap and remove finalizer from DocumentMarkerController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/SpellChecker.cpp

Issue 289323003: Move markerlists to Oilpan heap and remove finalizer from DocumentMarkerController (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Move DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/SpellChecker.cpp

diff --git a/Source/core/editing/SpellChecker.cpp b/Source/core/editing/SpellChecker.cpp

index 663c581cb39da55522f2b3e7de8b7b5c3ab6113e..11a148a614d0f5f395a9536ecc5d3625d6d3a5de 100644

--- a/Source/core/editing/SpellChecker.cpp

+++ b/Source/core/editing/SpellChecker.cpp

@@ -810,7 +810,7 @@ bool SpellChecker::selectionStartHasMarkerFor(DocumentMarker::MarkerType markerT

unsigned startOffset = static_cast<unsigned>(from);

unsigned endOffset = static_cast<unsigned>(from + length);

- Vector<DocumentMarker*> markers = m_frame.document()->markers().markersFor(node);

+ WillBeHeapVector<DocumentMarker*> markers = m_frame.document()->markers().markersFor(node);

for (size_t i = 0; i < markers.size(); ++i) {

DocumentMarker* marker = markers[i];

if (marker->startOffset() <= startOffset && endOffset <= marker->endOffset() && marker->type() == markerType)

« no previous file with comments | « Source/core/editing/SpellCheckRequester.cpp ('k') | Source/core/page/EventHandler.cpp » ('j') | no next file with comments »